Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issue 3003203002: [gardening] Re-enable vm/cc/UseDartApi on simdbc64 (Closed)

Created:
3 years, 4 months ago by kustermann
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[gardening] Re-enable vm/cc/UseDartApi on simdbc64 Running this in a loop locally did not reproduce any crash and the issue was filed in January, so the fundamental problem might have been fixed already. Due to the lack of more information in the bug report, the best thing is to renable the test, close the issue and see if the test flakes again. Closes https://github.com/dart-lang/sdk/issues/28499 R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/732a682e529b20b228e71b8ef8baf1f565d00779

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M runtime/tests/vm/vm.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
kustermann
3 years, 4 months ago (2017-08-23 11:39:36 UTC) #2
Vyacheslav Egorov (Google)
lgtm
3 years, 4 months ago (2017-08-23 18:38:50 UTC) #3
kustermann
3 years, 4 months ago (2017-08-24 09:16:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
732a682e529b20b228e71b8ef8baf1f565d00779 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698