Fix inlining annotations for AOT.

Fix inlining annotations for AOT.

We were only recording metadata positions when mirrors were enabled. Mirrors are not enabled for AOT, so this metadata became unavailable to the inliner. Now we always record metadata position.

The tree-shaker has been updated to know how to remove the metadata.

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/eed3b5e0bbe9ebaa54524f0beca1954eaed6c125

[rmacnak, 2017-08-23 00:52:07]

rmacnak@google.com changed reviewers:
+ asiva@google.com, cbernaschina@google.com, vegorov@google.com

[siva, 2017-08-23 00:56:30]

Maybe elaborate more in the description that the matadata was being done under
the option "use_mirrors" which is not turned on in the AOT mode resulting in
tests not working as intended.

LGTM

[rmacnak, 2017-08-23 01:19:26]

Description was changed from

==========
Fix inlining annotations for AOT.
==========

to

==========
Fix inlining annotations for AOT.

We were only recording metadata positions when mirrors were enabled. Mirrors are
not enabled for AOT, so this metadata became unavailable to the inliner. Now we
always record metadata position. The synthetic Field object this introduces will
be removed by the tree-shaker.
==========

[rmacnak, 2017-08-23 01:21:11]

On 2017/08/23 00:56:30, siva wrote:
> Maybe elaborate more in the description that the matadata was being done under
> the option "use_mirrors" which is not turned on in the AOT mode resulting in
> tests not working as intended.
> 
> LGTM

Added more description.

We have a couple dozen tests that now fail on AOT.

[rmacnak, 2017-08-24 19:02:08]

Description was changed from

==========
Fix inlining annotations for AOT.

We were only recording metadata positions when mirrors were enabled. Mirrors are
not enabled for AOT, so this metadata became unavailable to the inliner. Now we
always record metadata position. The synthetic Field object this introduces will
be removed by the tree-shaker.
==========

to

==========
Fix inlining annotations for AOT.

We were only recording metadata positions when mirrors were enabled. Mirrors are
not enabled for AOT, so this metadata became unavailable to the inliner. Now we
always record metadata position. 

The tree-shaker has been updated to know how to remove the metadata.
==========

[rmacnak, 2017-08-24 19:06:31]

PTAL. Updated the tree-shaker to remove metadata. I mistakenly thought that
metadata fields ended up in the regular library dictionary, but they actually
have separate storage.

[siva, 2017-08-24 21:35:50]

lgtm

https://codereview.chromium.org/3003183003/diff/20001/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/3003183003/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:1974: GrowableObjectArray& null_growable_list =
GrowableObjectArray::Handle(Z);
const GrowableObjec......

https://codereview.chromium.org/3003183003/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:1977: Field& null_field = Field::Handle(Z);
const Field& null_field

[rmacnak, 2017-08-24 23:31:53]

https://codereview.chromium.org/3003183003/diff/20001/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/3003183003/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:1974: GrowableObjectArray& null_growable_list =
GrowableObjectArray::Handle(Z);
On 2017/08/24 21:35:50, siva wrote:
> const GrowableObjec......

Done.

https://codereview.chromium.org/3003183003/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:1977: Field& null_field = Field::Handle(Z);
On 2017/08/24 21:35:50, siva wrote:
> const Field& null_field

Done.

[rmacnak, 2017-08-24 23:32:28]

Description was changed from

==========
Fix inlining annotations for AOT.

We were only recording metadata positions when mirrors were enabled. Mirrors are
not enabled for AOT, so this metadata became unavailable to the inliner. Now we
always record metadata position. 

The tree-shaker has been updated to know how to remove the metadata.
==========

to

==========
Fix inlining annotations for AOT.

We were only recording metadata positions when mirrors were enabled. Mirrors are
not enabled for AOT, so this metadata became unavailable to the inliner. Now we
always record metadata position.

The tree-shaker has been updated to know how to remove the metadata.

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/eed3b5e0bbe9ebaa54524f0beca1954eaed6c125
==========

[rmacnak, 2017-08-24 23:32:29]

Committed patchset #3 (id:40001) manually as
eed3b5e0bbe9ebaa54524f0beca1954eaed6c125 (presubmit successful).