Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Unified Diff: telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py

Issue 3003143002: [Telemetry] Use --ignore-certificate-errors-spki-list to bypass cert errors (Closed)
Patch Set: fix test Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | telemetry/telemetry/internal/backends/chrome/chrome_browser_backend_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py
diff --git a/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py b/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py
index 908239d798e35054745a91fcab9a802e15298df9..51d98fb937ef8f5817a8556ecb49338649708b28 100644
--- a/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py
+++ b/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py
@@ -128,9 +128,13 @@ class ChromeBrowserBackend(browser_backend.BrowserBackend):
proxy_port = network_backend.forwarder.port_pair.remote_port
replay_args.append('--proxy-server=socks://localhost:%s' % proxy_port)
if not network_backend.is_test_ca_installed:
- # Ignore certificate errors if the platform backend has not created
- # and installed a root certificate.
- replay_args.append('--ignore-certificate-errors')
+ # Ignore certificate errors for certs that are signed with Wpr's root.
+ # openssl x509 -noout -pubkey -in wpr_cert.pem |
+ # openssl pkey -pubin -outform der |
+ # openssl dgst -sha256 -binary |
+ # base64
nednguyen 2017/08/22 15:40:50 I think this string probably should be managed by
xunjieli 2017/08/22 21:05:43 Done.
+ replay_args.append('--ignore-certificate-errors-spki-list='
nednguyen 2017/08/22 15:40:50 nits: also link the discussion in crbug.com/757508
+ 'PhrPvGIaAMmd29hj8BCZOq096yj7uMpRNHpn5PDxI6I=')
return replay_args
def HasBrowserFinishedLaunching(self):
« no previous file with comments | « no previous file | telemetry/telemetry/internal/backends/chrome/chrome_browser_backend_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698