Migrated test block 219 to Dart 2.0.

Migrated test block 219 to Dart 2.0.

No major changes. Some tests that rely on noSuchMethod needed to have
some 'var's changed to 'dynamic's.

BUG=
R=rnystrom@google.com

Committed: https://github.com/dart-lang/sdk/commit/64105ee014cbdd441f90029f8dca49de42af16c8

[bkonyi, 2017-08-22 12:40:23]

bkonyi@google.com changed reviewers:
+ rnystrom@google.com

[rmacnak, 2017-08-22 16:59:50]

rmacnak@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2017-08-22 16:59:51]

not lgtm

https://codereview.chromium.org/3003123002/diff/20001/tests/lib_2/mirrors/del...
File tests/lib_2/mirrors/delegate_class_test.dart (left):

https://codereview.chromium.org/3003123002/diff/20001/tests/lib_2/mirrors/del...
tests/lib_2/mirrors/delegate_class_test.dart:18: return 'unobservable value';
This must be kept.

If this is not expressible in strong mode, the Dart test must be kept around.

https://codereview.chromium.org/3003123002/diff/20001/tests/lib_2/mirrors/del...
File tests/lib_2/mirrors/delegate_library_test.dart (left):

https://codereview.chromium.org/3003123002/diff/20001/tests/lib_2/mirrors/del...
tests/lib_2/mirrors/delegate_library_test.dart:17: return 'unobservable value';
This must be kept.

https://codereview.chromium.org/3003123002/diff/20001/tests/lib_2/mirrors/del...
File tests/lib_2/mirrors/delegate_test.dart (left):

https://codereview.chromium.org/3003123002/diff/20001/tests/lib_2/mirrors/del...
tests/lib_2/mirrors/delegate_test.dart:18: return 'unobservable value';
This must be kept.

[Bob Nystrom, 2017-08-23 22:22:07]

lgtm

https://codereview.chromium.org/3003123002/diff/20001/tests/lib_2/mirrors/del...
File tests/lib_2/mirrors/delegate_class_test.dart (left):

https://codereview.chromium.org/3003123002/diff/20001/tests/lib_2/mirrors/del...
tests/lib_2/mirrors/delegate_class_test.dart:18: return 'unobservable value';
On 2017/08/22 16:59:51, rmacnak wrote:
> This must be kept.
> 
> If this is not expressible in strong mode, the Dart test must be kept around.

According to the Dart 2.0 language, the static return type of a setter is void
and it is a compile error for a member to return a value that is not assignable
to its return type. This setter is not valid Dart code.

If you want to preserve this test for validating some unspecified behavior or
implementation detail of the VM, that's totally fine. You just need to copy it
out of lib_2/ into some VM-specific testing directory.

lib_2/, corelib_2/, and language_2/ are only for testing the official Dart 2.0
language. I'm guessing you wouldn't feel comfortable seeing a test like this
under language_2/:

main() {
  Expect.equals(1, 1.0); // Ints are doubles on the web.
}

Likewise, we don't want tests of VM-specific behavior in there either.

https://codereview.chromium.org/3003123002/diff/20001/tests/lib_2/mirrors/mir...
File tests/lib_2/mirrors/mirrors_test.dart (right):

https://codereview.chromium.org/3003123002/diff/20001/tests/lib_2/mirrors/mir...
tests/lib_2/mirrors/mirrors_test.dart:86: }
Do we still need this if we're not supporting mirrors in dart2js any more?

[rmacnak, 2017-08-23 23:32:05]

https://codereview.chromium.org/3003123002/diff/20001/tests/lib_2/mirrors/del...
File tests/lib_2/mirrors/delegate_class_test.dart (left):

https://codereview.chromium.org/3003123002/diff/20001/tests/lib_2/mirrors/del...
tests/lib_2/mirrors/delegate_class_test.dart:18: return 'unobservable value';
On 2017/08/23 22:22:07, Bob Nystrom wrote:
> On 2017/08/22 16:59:51, rmacnak wrote:
> > This must be kept.
> > 
> > If this is not expressible in strong mode, the Dart test must be kept
around.
> 
> According to the Dart 2.0 language, the static return type of a setter is void
> and it is a compile error for a member to return a value that is not
assignable
> to its return type. This setter is not valid Dart code.
> 
> If you want to preserve this test for validating some unspecified behavior or
> implementation detail of the VM, that's totally fine. You just need to copy it
> out of lib_2/ into some VM-specific testing directory.
> 
> lib_2/, corelib_2/, and language_2/ are only for testing the official Dart 2.0
> language. I'm guessing you wouldn't feel comfortable seeing a test like this
> under language_2/:
> 
> main() {
>   Expect.equals(1, 1.0); // Ints are doubles on the web.
> }
> 
> Likewise, we don't want tests of VM-specific behavior in there either.

This behavior is not VM-specific and is well-specified by Dart (not to be
confused with Dart 2). As long as we are shipping a Dart SDK, we must maintain
test coverage for it.

[Bob Nystrom, 2017-08-24 16:15:57]

On 2017/08/23 23:32:05, rmacnak wrote:
>
https://codereview.chromium.org/3003123002/diff/20001/tests/lib_2/mirrors/del...
> File tests/lib_2/mirrors/delegate_class_test.dart (left):
> 
>
https://codereview.chromium.org/3003123002/diff/20001/tests/lib_2/mirrors/del...
> tests/lib_2/mirrors/delegate_class_test.dart:18: return 'unobservable value';
> On 2017/08/23 22:22:07, Bob Nystrom wrote:
> > On 2017/08/22 16:59:51, rmacnak wrote:
> > > This must be kept.
> > > 
> > > If this is not expressible in strong mode, the Dart test must be kept
> around.
> > 
> > According to the Dart 2.0 language, the static return type of a setter is
void
> > and it is a compile error for a member to return a value that is not
> assignable
> > to its return type. This setter is not valid Dart code.
> > 
> > If you want to preserve this test for validating some unspecified behavior
or
> > implementation detail of the VM, that's totally fine. You just need to copy
it
> > out of lib_2/ into some VM-specific testing directory.
> > 
> > lib_2/, corelib_2/, and language_2/ are only for testing the official Dart
2.0
> > language. I'm guessing you wouldn't feel comfortable seeing a test like this
> > under language_2/:
> > 
> > main() {
> >   Expect.equals(1, 1.0); // Ints are doubles on the web.
> > }
> > 
> > Likewise, we don't want tests of VM-specific behavior in there either.
> 
> This behavior is not VM-specific and is well-specified by Dart (not to be
> confused with Dart 2). As long as we are shipping a Dart SDK, we must maintain
> test coverage for it.

We are no longer shipping a Dart 1.0 SDK, only 2.0. Behavior specified by older
versions of the spec is no longer supported or tested. Just as we no longer have
tests of the "#import" syntax, default classes, rationals, and the argument test
operator, we are no longer going to have tests of the old optional type system.

If the VM itself wants to maintain support for this no-longer-specified
behavior, that's fine, but those tests belong in an area specific to the VM.

– bob

[bkonyi, 2017-08-30 14:52:06]

Description was changed from

==========
Migrated test block 219 to Dart 2.0.

No major changes. Some tests that rely on noSuchMethod needed to have
some 'var's changed to 'dynamic's.

BUG=
==========

to

==========
Migrated test block 219 to Dart 2.0.

No major changes. Some tests that rely on noSuchMethod needed to have
some 'var's changed to 'dynamic's.

BUG=
R=rnystrom@google.com

Committed:
https://github.com/dart-lang/sdk/commit/64105ee014cbdd441f90029f8dca49de42af16c8
==========

[bkonyi, 2017-08-30 14:52:08]

Committed patchset #2 (id:20001) manually as
64105ee014cbdd441f90029f8dca49de42af16c8.