src/x64/full-codegen-x64.cc - Issue 300283003: FastCloneShallowArrayStub should not be used it the length of the array is too big as it could even…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/full-codegen-x64.cc

Issue 300283003: FastCloneShallowArrayStub should not be used it the length of the array is too big as it could even… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/full-codegen-x64.cc

diff --git a/src/x64/full-codegen-x64.cc b/src/x64/full-codegen-x64.cc

index 97c9c5cdebc0ef9b35bd9293a7f49ec090491a11..a031a59eae531f2bd6b606c292eb433824add4de 100644

--- a/src/x64/full-codegen-x64.cc

+++ b/src/x64/full-codegen-x64.cc

@@ -1776,7 +1776,7 @@ void FullCodeGenerator::VisitArrayLiteral(ArrayLiteral* expr) {

allocation_site_mode = DONT_TRACK_ALLOCATION_SITE;

}

- if (expr->depth() > 1) {

+ if (expr->depth() > 1 || length > JSObject::kInitialMaxFastElementArray) {

__ movp(rbx, Operand(rbp, JavaScriptFrameConstants::kFunctionOffset));

__ Push(FieldOperand(rbx, JSFunction::kLiteralsOffset));

__ Push(Smi::FromInt(expr->literal_index()));

« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | src/x87/full-codegen-x87.cc » ('j') | no next file with comments »