src/json-stringifier.h - Issue 300283002: Introduce FieldIndex to unify and abstract property/field offset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/json-stringifier.h

Issue 300283002: Introduce FieldIndex to unify and abstract property/field offset (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fix mutable boxed double runtime function Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/json-stringifier.h

diff --git a/src/json-stringifier.h b/src/json-stringifier.h

index f6149ae36d850fc7f85a5d90c0b07b5dd14e2c77..23927b162edc09514d3cadb77efa3a604ed5fb32 100644

--- a/src/json-stringifier.h

+++ b/src/json-stringifier.h

@@ -657,10 +657,8 @@ BasicJsonStringifier::Result BasicJsonStringifier::SerializeJSObject(

if (details.IsDontEnum()) continue;

Handle<Object> property;

if (details.type() == FIELD && *map == object->map()) {

- property = Handle<Object>(

- object->RawFastPropertyAt(

- map->instance_descriptors()->GetFieldIndex(i)),

- isolate_);

+ property = Handle<Object>(object->RawFastPropertyAt(

+ FieldIndex::ForDescriptor(*map, i)), isolate_);

} else {

ASSIGN_RETURN_ON_EXCEPTION_VALUE(

isolate_, property,

« no previous file with comments | « src/json-parser.h ('k') | src/objects.h » ('j') | no next file with comments »