Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py

Issue 3002793002: [Telemetry] fix run_benchmark crash on CrOS (Closed)
Patch Set: [Telemetry] fix run_benchmark crash on CrOS Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py
diff --git a/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py b/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py
index f5b02fb12b6163871e6036e532abd7b115dd8024..908239d798e35054745a91fcab9a802e15298df9 100644
--- a/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py
+++ b/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py
@@ -146,6 +146,12 @@ class ChromeBrowserBackend(browser_backend.BrowserBackend):
remote_devtools_port: The remote devtools port, if
any. Otherwise assumed to be the same as self._port.
"""
+ if self._devtools_client:
+ # In case we are launching a second browser instance (as is done by
+ # the CrOS backend), ensure that the old devtools_client is closed,
+ # otherwise re-creating it will fail.
+ self._devtools_client.Close()
+ self._devtools_client = None
try:
timeout = self.browser_options.browser_startup_timeout
py_utils.WaitFor(self.HasBrowserFinishedLaunching, timeout=timeout)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698