Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: tools/gardening/lib/src/client.dart

Issue 3002743002: Fix buildbot_data_test (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gardening/lib/src/buildbot_structures.dart ('k') | tools/gardening/test/buildbot_data_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gardening/lib/src/client.dart
diff --git a/tools/gardening/lib/src/client.dart b/tools/gardening/lib/src/client.dart
index 0257f5c8a1519fcd55dffc594a109d9c97486185..eb09ac8f38554dff970e3ddef0a6a66ebdd1d277 100644
--- a/tools/gardening/lib/src/client.dart
+++ b/tools/gardening/lib/src/client.dart
@@ -26,8 +26,11 @@ abstract class BuildbotClient {
class HttpBuildbotClient implements BuildbotClient {
final HttpClient _client = new HttpClient();
+ static const int maxSkips = 3;
+
@override
Future<BuildResult> readResult(BuildUri buildUri) async {
+ int skips = 0;
Duration timeout;
if (buildUri.buildNumber < 0) {
timeout = new Duration(seconds: 1);
@@ -43,13 +46,15 @@ class HttpBuildbotClient implements BuildbotClient {
try {
return await readBuildResultFromHttp(_client, buildUri, timeout);
} on TimeoutException {
- if (timeout != null) {
+ if (timeout != null && skips < maxSkips) {
+ skips++;
skipToPreviousBuildNumber();
continue;
}
return null;
} on HttpException {
- if (timeout != null) {
+ if (timeout != null && skips < maxSkips) {
+ skips++;
skipToPreviousBuildNumber();
continue;
}
« no previous file with comments | « tools/gardening/lib/src/buildbot_structures.dart ('k') | tools/gardening/test/buildbot_data_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698