Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 3002743002: Fix buildbot_data_test (Closed)

Created:
3 years, 4 months ago by Johnni Winther
Modified:
3 years, 4 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -34 lines) Patch
M tools/gardening/lib/src/buildbot_data.dart View 1 chunk +19 lines, -1 line 0 comments Download
M tools/gardening/lib/src/buildbot_structures.dart View 4 chunks +4 lines, -15 lines 0 comments Download
M tools/gardening/lib/src/client.dart View 2 chunks +7 lines, -2 lines 0 comments Download
M tools/gardening/test/buildbot_data_test.dart View 2 chunks +18 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 4 months ago (2017-08-16 12:38:14 UTC) #2
floitsch
LGTM.
3 years, 4 months ago (2017-08-16 12:56:32 UTC) #3
Johnni Winther
3 years, 4 months ago (2017-08-16 13:31:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8f4d7828dfed1872bd2bcbce4bde64d02fca61b4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698