Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: runtime/bin/dfe.cc

Issue 3002733002: [vm,aot,kernel] Fix AOT snapshot creation with kernel front-end (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/dfe.h ('k') | runtime/bin/main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/dfe.cc
diff --git a/runtime/bin/dfe.cc b/runtime/bin/dfe.cc
index 23a272361cbe3bc93654737ab1fc9591c1e7524c..250b60cd9c5e1355b117065133133bf81792ca3e 100644
--- a/runtime/bin/dfe.cc
+++ b/runtime/bin/dfe.cc
@@ -20,7 +20,6 @@ DFE::DFE()
platform_binary_filename_(NULL),
vmservice_io_binary_filename_(NULL),
kernel_platform_(NULL),
- kernel_vmservice_io_(NULL),
kernel_file_specified_(false) {}
DFE::~DFE() {
@@ -35,15 +34,6 @@ DFE::~DFE() {
delete reinterpret_cast<kernel::Program*>(kernel_platform_);
kernel_platform_ = NULL;
}
-
- if (kernel_vmservice_io_ != NULL) {
- delete reinterpret_cast<kernel::Program*>(kernel_vmservice_io_);
- kernel_vmservice_io_ = NULL;
- }
-}
-
-void DFE::clear_kernel_vmservice_io() {
- kernel_vmservice_io_ = NULL;
}
void DFE::SetKernelBinaries(const char* name) {
@@ -118,15 +108,15 @@ void* DFE::CompileAndReadScript(const char* script_uri,
return NULL;
}
-void* DFE::ReadPlatform() {
- return kernel_platform_ = ReadScript(platform_binary_filename_);
+void* DFE::ReadPlatform() const {
+ return ReadScript(platform_binary_filename_);
}
-void* DFE::ReadVMServiceIO() {
- return kernel_vmservice_io_ = ReadScript(vmservice_io_binary_filename_);
+void* DFE::ReadVMServiceIO() const {
+ return ReadScript(vmservice_io_binary_filename_);
}
-void* DFE::ReadScript(const char* script_uri) {
+void* DFE::ReadScript(const char* script_uri) const {
const uint8_t* buffer = NULL;
intptr_t buffer_length = -1;
bool result = TryReadKernelFile(script_uri, &buffer, &buffer_length);
@@ -138,7 +128,7 @@ void* DFE::ReadScript(const char* script_uri) {
bool DFE::TryReadKernelFile(const char* script_uri,
const uint8_t** kernel_ir,
- intptr_t* kernel_ir_size) {
+ intptr_t* kernel_ir_size) const {
*kernel_ir = NULL;
*kernel_ir_size = -1;
void* script_file = DartUtils::OpenFile(script_uri, false);
« no previous file with comments | « runtime/bin/dfe.h ('k') | runtime/bin/main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698