Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 3002713002: Fix logic for locating dartfmt (Closed)

Created:
3 years, 4 months ago by Paul Berry
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix logic for locating dartfmt When dartfmt is run as part of tests to verify that code generation is up to date, the directory containing the resolved executable is sometimes .../out/Release.../, but dartfmt is located in .../out/Release.../dart-sdk/bin/dartfmt. So we need to look in both the resolved executable directory and in dart-sdk/bin for dartfmt. R=devoncarew@google.com Committed: https://github.com/dart-lang/sdk/commit/19e1f44be36828301cf6c5d53c5acf960dd27e0e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M pkg/front_end/lib/src/codegen/tools.dart View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 4 months ago (2017-08-15 19:48:16 UTC) #2
devoncarew
lgtm > .../out/Release.../ Hmm, interesting. I would have thought that we could rely on the ...
3 years, 4 months ago (2017-08-15 20:29:33 UTC) #3
Paul Berry
3 years, 4 months ago (2017-08-15 20:32:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
19e1f44be36828301cf6c5d53c5acf960dd27e0e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698