Resynthesize assert constructor initializers and parameter references.

Resynthesize assert constructor initializers and parameter references.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/46f0940a0a5c3e6000888c585a5a489089c9ad4f

[Paul Berry, 2017-08-15 16:54:39]

lgtm

https://codereview.chromium.org/3002633002/diff/1/pkg/analyzer/lib/src/kernel...
File pkg/analyzer/lib/src/kernel/resynthesize.dart (right):

https://codereview.chromium.org/3002633002/diff/1/pkg/analyzer/lib/src/kernel...
pkg/analyzer/lib/src/kernel/resynthesize.dart:351: return null;
Do we ever expect to reach this?  Does the caller propery handle a return value
of `null`?

If the answer to either question is no, then we should probably throw an
exception here.  Or if you think that's too dangerous, then maybe an assertion,
so that at least we have a chance of discovering the bug during testing.

[scheglov, 2017-08-23 17:06:27]

https://codereview.chromium.org/3002633002/diff/1/pkg/analyzer/lib/src/kernel...
File pkg/analyzer/lib/src/kernel/resynthesize.dart (right):

https://codereview.chromium.org/3002633002/diff/1/pkg/analyzer/lib/src/kernel...
pkg/analyzer/lib/src/kernel/resynthesize.dart:351: return null;
On 2017/08/15 16:54:39, Paul Berry wrote:
> Do we ever expect to reach this?  Does the caller propery handle a return
value
> of `null`?
> 
> If the answer to either question is no, then we should probably throw an
> exception here.  Or if you think that's too dangerous, then maybe an
assertion,
> so that at least we have a chance of discovering the bug during testing.

Done.

[scheglov, 2017-08-23 17:06:54]

Description was changed from

==========
Resynthesize assert constructor initializers and parameter references.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=
==========

to

==========
Resynthesize assert constructor initializers and parameter references.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/46f0940a0a5c3e6000888c585a5a489089c9ad4f
==========

[scheglov, 2017-08-23 17:06:56]

Committed patchset #1 (id:1) manually as
46f0940a0a5c3e6000888c585a5a489089c9ad4f (presubmit successful).