Revert "Revert of add colortable support to imagegenerator (https://codereview.chromium.org/3044430…

Revert "Revert of add colortable support to imagegenerator (https://codereview.chromium.org/304443003/)"

Fix is to add colortable param to installPixels()

This reverts commit 924205aaf2e0c3c65dda13e0eaccde3e7b2a5c40.

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=14958

[scroggo, 2014-05-28 18:16:35]

1gtm, although it's hard to see what's new here (an upload before the new
changes would have been helpful), and it seems to be failing some gms.

https://codereview.chromium.org/300263005/diff/1/src/image/SkImage_Raster.cpp
File src/image/SkImage_Raster.cpp (right):

https://codereview.chromium.org/300263005/diff/1/src/image/SkImage_Raster.cpp...
src/image/SkImage_Raster.cpp:99: fBitmap.installPixels(info, addr, rowBytes,
ctable, release_data, data);
Why not just pass NULL here?

[reed1, 2014-05-28 18:36:43]

https://codereview.chromium.org/300263005/diff/1/src/image/SkImage_Raster.cpp
File src/image/SkImage_Raster.cpp (right):

https://codereview.chromium.org/300263005/diff/1/src/image/SkImage_Raster.cpp...
src/image/SkImage_Raster.cpp:99: fBitmap.installPixels(info, addr, rowBytes,
ctable, release_data, data);
On 2014/05/28 18:16:36, scroggo wrote:
> Why not just pass NULL here?

Documentation. Not required.

[scroggo, 2014-05-28 21:21:18]

lgtm

[reed2, 2014-05-29 02:21:52]

The CQ bit was checked by reed@chromium.org

[commit-bot: I haz the power, 2014-05-29 02:22:25]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/reed@google.com/300263005/1

[commit-bot: I haz the power, 2014-05-29 02:22:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-29 02:22:46]

Failed to apply patch for gyp/skia_for_chromium_defines.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file gyp/skia_for_chromium_defines.gypi
  Hunk #1 FAILED at 16.
  1 out of 1 hunk FAILED -- saving rejects to file
gyp/skia_for_chromium_defines.gypi.rej

Patch:       gyp/skia_for_chromium_defines.gypi
Index: gyp/skia_for_chromium_defines.gypi
diff --git a/gyp/skia_for_chromium_defines.gypi
b/gyp/skia_for_chromium_defines.gypi
index
c114b7142e6b4d54803ab4ed5f5d7f26f10666e1..a47b391c3c463b54d75387fb197c2c02d55b4c7c
100644
--- a/gyp/skia_for_chromium_defines.gypi
+++ b/gyp/skia_for_chromium_defines.gypi
@@ -16,6 +16,7 @@
       'SK_SUPPORT_LEGACY_GETTOPDEVICE',
       'SK_SUPPORT_LEGACY_ASIMAGEINFO',
       'SK_SUPPORT_LEGACY_N32_NAME',
+      'SK_SUPPORT_LEGACY_IMAGEGENERATORAPI',
     ],
   },
 }

[reed1, 2014-05-29 12:45:52]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-05-29 12:46:30]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/reed@google.com/300263005/10001

[commit-bot: I haz the power, 2014-05-29 15:57:41]

Change committed as 14958