Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: net/quic/congestion_control/hybrid_slow_start_test.cc

Issue 300263003: Update naming of members per style guideline with clang_tidy. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/logging.h" 5 #include "base/logging.h"
6 #include "base/memory/scoped_ptr.h" 6 #include "base/memory/scoped_ptr.h"
7 #include "net/quic/congestion_control/hybrid_slow_start.h" 7 #include "net/quic/congestion_control/hybrid_slow_start.h"
8 #include "net/quic/test_tools/mock_clock.h" 8 #include "net/quic/test_tools/mock_clock.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
11 namespace net { 11 namespace net {
12 namespace test { 12 namespace test {
13 13
14 class HybridSlowStartTest : public ::testing::Test { 14 class HybridSlowStartTest : public ::testing::Test {
15 protected: 15 protected:
16 HybridSlowStartTest() 16 HybridSlowStartTest()
17 : one_ms_(QuicTime::Delta::FromMilliseconds(1)), 17 : one_ms_(QuicTime::Delta::FromMilliseconds(1)),
18 rtt_(QuicTime::Delta::FromMilliseconds(60)) { 18 rtt_(QuicTime::Delta::FromMilliseconds(60)) {
19 } 19 }
20 virtual void SetUp() { 20 virtual void SetUp() {
21 slowStart_.reset(new HybridSlowStart(&clock_)); 21 slow_start_.reset(new HybridSlowStart(&clock_));
22 } 22 }
23 const QuicTime::Delta one_ms_; 23 const QuicTime::Delta one_ms_;
24 const QuicTime::Delta rtt_; 24 const QuicTime::Delta rtt_;
25 MockClock clock_; 25 MockClock clock_;
26 scoped_ptr<HybridSlowStart> slowStart_; 26 scoped_ptr<HybridSlowStart> slow_start_;
27 }; 27 };
28 28
29 TEST_F(HybridSlowStartTest, Simple) { 29 TEST_F(HybridSlowStartTest, Simple) {
30 QuicPacketSequenceNumber sequence_number = 1; 30 QuicPacketSequenceNumber sequence_number = 1;
31 QuicPacketSequenceNumber end_sequence_number = 3; 31 QuicPacketSequenceNumber end_sequence_number = 3;
32 slowStart_->StartReceiveRound(end_sequence_number); 32 slow_start_->StartReceiveRound(end_sequence_number);
33 33
34 EXPECT_FALSE(slowStart_->IsEndOfRound(sequence_number++)); 34 EXPECT_FALSE(slow_start_->IsEndOfRound(sequence_number++));
35 35
36 // Test duplicates. 36 // Test duplicates.
37 EXPECT_FALSE(slowStart_->IsEndOfRound(sequence_number)); 37 EXPECT_FALSE(slow_start_->IsEndOfRound(sequence_number));
38 38
39 EXPECT_FALSE(slowStart_->IsEndOfRound(sequence_number++)); 39 EXPECT_FALSE(slow_start_->IsEndOfRound(sequence_number++));
40 EXPECT_TRUE(slowStart_->IsEndOfRound(sequence_number++)); 40 EXPECT_TRUE(slow_start_->IsEndOfRound(sequence_number++));
41 41
42 // Test without a new registered end_sequence_number; 42 // Test without a new registered end_sequence_number;
43 EXPECT_TRUE(slowStart_->IsEndOfRound(sequence_number++)); 43 EXPECT_TRUE(slow_start_->IsEndOfRound(sequence_number++));
44 44
45 end_sequence_number = 20; 45 end_sequence_number = 20;
46 slowStart_->StartReceiveRound(end_sequence_number); 46 slow_start_->StartReceiveRound(end_sequence_number);
47 while (sequence_number < end_sequence_number) { 47 while (sequence_number < end_sequence_number) {
48 EXPECT_FALSE(slowStart_->IsEndOfRound(sequence_number++)); 48 EXPECT_FALSE(slow_start_->IsEndOfRound(sequence_number++));
49 } 49 }
50 EXPECT_TRUE(slowStart_->IsEndOfRound(sequence_number++)); 50 EXPECT_TRUE(slow_start_->IsEndOfRound(sequence_number++));
51 } 51 }
52 52
53 // TODO(ianswett): Add tests which more realistically invoke the methods, 53 // TODO(ianswett): Add tests which more realistically invoke the methods,
54 // simulating how actual acks arrive and packets are sent. 54 // simulating how actual acks arrive and packets are sent.
55 TEST_F(HybridSlowStartTest, AckTrain) { 55 TEST_F(HybridSlowStartTest, AckTrain) {
56 // At a typical RTT 60 ms, assuming that the inter arrival is 1 ms, 56 // At a typical RTT 60 ms, assuming that the inter arrival is 1 ms,
57 // we expect to be able to send a burst of 30 packet before we trigger the 57 // we expect to be able to send a burst of 30 packet before we trigger the
58 // ack train detection. 58 // ack train detection.
59 const int kMaxLoopCount = 5; 59 const int kMaxLoopCount = 5;
60 QuicPacketSequenceNumber sequence_number = 2; 60 QuicPacketSequenceNumber sequence_number = 2;
61 QuicPacketSequenceNumber end_sequence_number = 2; 61 QuicPacketSequenceNumber end_sequence_number = 2;
62 for (int burst = 0; burst < kMaxLoopCount; ++burst) { 62 for (int burst = 0; burst < kMaxLoopCount; ++burst) {
63 slowStart_->StartReceiveRound(end_sequence_number); 63 slow_start_->StartReceiveRound(end_sequence_number);
64 do { 64 do {
65 clock_.AdvanceTime(one_ms_); 65 clock_.AdvanceTime(one_ms_);
66 EXPECT_FALSE(slowStart_->ShouldExitSlowStart(rtt_, rtt_, 100)); 66 EXPECT_FALSE(slow_start_->ShouldExitSlowStart(rtt_, rtt_, 100));
67 } while (!slowStart_->IsEndOfRound(sequence_number++)); 67 } while (!slow_start_->IsEndOfRound(sequence_number++));
68 end_sequence_number *= 2; // Exponential growth. 68 end_sequence_number *= 2; // Exponential growth.
69 } 69 }
70 slowStart_->StartReceiveRound(end_sequence_number); 70 slow_start_->StartReceiveRound(end_sequence_number);
71 71
72 for (int n = 0; n < 29 && !slowStart_->IsEndOfRound(sequence_number++); ++n) { 72 for (int n = 0;
73 n < 29 && !slow_start_->IsEndOfRound(sequence_number++); ++n) {
73 clock_.AdvanceTime(one_ms_); 74 clock_.AdvanceTime(one_ms_);
74 EXPECT_FALSE(slowStart_->ShouldExitSlowStart(rtt_, rtt_, 100)); 75 EXPECT_FALSE(slow_start_->ShouldExitSlowStart(rtt_, rtt_, 100));
75 } 76 }
76 clock_.AdvanceTime(one_ms_); 77 clock_.AdvanceTime(one_ms_);
77 EXPECT_TRUE(slowStart_->ShouldExitSlowStart(rtt_, rtt_, 100)); 78 EXPECT_TRUE(slow_start_->ShouldExitSlowStart(rtt_, rtt_, 100));
78 } 79 }
79 80
80 TEST_F(HybridSlowStartTest, Delay) { 81 TEST_F(HybridSlowStartTest, Delay) {
81 // We expect to detect the increase at +1/16 of the RTT; hence at a typical 82 // We expect to detect the increase at +1/16 of the RTT; hence at a typical
82 // RTT of 60ms the detection will happen at 63.75 ms. 83 // RTT of 60ms the detection will happen at 63.75 ms.
83 const int kHybridStartMinSamples = 8; // Number of acks required to trigger. 84 const int kHybridStartMinSamples = 8; // Number of acks required to trigger.
84 85
85 QuicPacketSequenceNumber end_sequence_number = 1; 86 QuicPacketSequenceNumber end_sequence_number = 1;
86 slowStart_->StartReceiveRound(end_sequence_number++); 87 slow_start_->StartReceiveRound(end_sequence_number++);
87 88
88 // Will not trigger since our lowest RTT in our burst is the same as the long 89 // Will not trigger since our lowest RTT in our burst is the same as the long
89 // term RTT provided. 90 // term RTT provided.
90 for (int n = 0; n < kHybridStartMinSamples; ++n) { 91 for (int n = 0; n < kHybridStartMinSamples; ++n) {
91 EXPECT_FALSE(slowStart_->ShouldExitSlowStart( 92 EXPECT_FALSE(slow_start_->ShouldExitSlowStart(
92 rtt_.Add(QuicTime::Delta::FromMilliseconds(n)), rtt_, 100)); 93 rtt_.Add(QuicTime::Delta::FromMilliseconds(n)), rtt_, 100));
93 } 94 }
94 slowStart_->StartReceiveRound(end_sequence_number++); 95 slow_start_->StartReceiveRound(end_sequence_number++);
95 for (int n = 1; n < kHybridStartMinSamples; ++n) { 96 for (int n = 1; n < kHybridStartMinSamples; ++n) {
96 EXPECT_FALSE(slowStart_->ShouldExitSlowStart( 97 EXPECT_FALSE(slow_start_->ShouldExitSlowStart(
97 rtt_.Add(QuicTime::Delta::FromMilliseconds(n + 5)), rtt_, 100)); 98 rtt_.Add(QuicTime::Delta::FromMilliseconds(n + 5)), rtt_, 100));
98 } 99 }
99 // Expect to trigger since all packets in this burst was above the long term 100 // Expect to trigger since all packets in this burst was above the long term
100 // RTT provided. 101 // RTT provided.
101 EXPECT_TRUE(slowStart_->ShouldExitSlowStart( 102 EXPECT_TRUE(slow_start_->ShouldExitSlowStart(
102 rtt_.Add(QuicTime::Delta::FromMilliseconds(5)), rtt_, 100)); 103 rtt_.Add(QuicTime::Delta::FromMilliseconds(5)), rtt_, 100));
103 } 104 }
104 105
105 } // namespace test 106 } // namespace test
106 } // namespace net 107 } // namespace net
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698