Remove race condition in Observatory memory page

Remove race condition in Observatory memory page

During the computation of the hover labels in the memory dashboard graph
the format functions were reading shared state that can be out of sync
if an update is ongoing.

To fix the error is enough to use the local copies instead.
To prevent this error in the future the format functions now are marked
as static and the analyzer will signal if they are accessing shared state.

R=asiva@google.com, rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/470749c38c1ba50689ef80f0a1a013b834684f97

[cbernaschina, 2017-08-14 16:49:11]

cbernaschina@google.com changed reviewers:
+ asiva@google.com, bkonyi@google.com, rmacnak@google.com

[siva, 2017-08-14 20:17:22]

lgtm

[rmacnak, 2017-08-14 20:38:29]

lgtm

[cbernaschina, 2017-08-14 21:39:17]

Description was changed from

==========
Remove race condition in Observatory memory page

During the computation of the hover labels in the memory dashboard graph
the format functions were reading shared state that can be out of sync
if an update is ongoing.

To fix the error is enough to use the local copies instead.
To prevent this error in the future the format functions now are marked
as static and the analyzer will signal if they are accessing shared state.
==========

to

==========
Remove race condition in Observatory memory page

During the computation of the hover labels in the memory dashboard graph
the format functions were reading shared state that can be out of sync
if an update is ongoing.

To fix the error is enough to use the local copies instead.
To prevent this error in the future the format functions now are marked
as static and the analyzer will signal if they are accessing shared state.

R=asiva@google.com, rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/470749c38c1ba50689ef80f0a1a013b834684f97
==========

[cbernaschina, 2017-08-14 21:39:18]

Committed patchset #1 (id:1) manually as
470749c38c1ba50689ef80f0a1a013b834684f97 (presubmit successful).