generate synthetic and error tokens when missing digit

generate synthetic and error tokens when missing digit

Fix #30321

R=ahe@google.com

Committed: https://github.com/dart-lang/sdk/commit/63991ba171ddd72a1ca80fd019d61a544419d311

[danrubel, 2017-08-12 01:56:59]

danrubel@google.com changed reviewers:
+ ahe@google.com

[ahe, 2017-08-14 06:28:51]

I would like to see a shared test for this as well. Generally, I think we need
to get in the habit of adding a shared test to ensure that dart2js doesn't
crash.

Otherwise, LGTM!

[danrubel, 2017-08-14 13:09:45]

Description was changed from

==========
generate synthetic and error tokens when missing digit

Fix #30321
==========

to

==========
generate synthetic and error tokens when missing digit

Fix #30321

R=ahe@google.com

Committed:
https://github.com/dart-lang/sdk/commit/63991ba171ddd72a1ca80fd019d61a544419d311
==========

[danrubel, 2017-08-14 13:09:47]

Committed patchset #2 (id:20001) manually as
63991ba171ddd72a1ca80fd019d61a544419d311 (presubmit successful).

[danrubel, 2017-08-14 13:10:26]

On 2017/08/14 06:28:51, ahe wrote:
> I would like to see a shared test for this as well. Generally, I think we need
> to get in the habit of adding a shared test to ensure that dart2js doesn't
> crash.
> 
> Otherwise, LGTM!

Good idea. I'll add one in a subsequent CL.

[danrubel, 2017-08-15 16:25:35]

On 2017/08/14 13:10:26, danrubel wrote:
> On 2017/08/14 06:28:51, ahe wrote:
> > I would like to see a shared test for this as well. Generally, I think we
need
> > to get in the habit of adding a shared test to ensure that dart2js doesn't
> > crash.
> > 
> > Otherwise, LGTM!
> 
> Good idea. I'll add one in a subsequent CL.

See https://codereview.chromium.org/2995943002/