Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 3002473002: Check service availability on editor repository (Closed)

Created:
3 years, 4 months ago by cbernaschina
Modified:
3 years, 4 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Check service availability on editor repository The editor repository in Observatory was assuming is some situations the presence of an openSourceLocation service even if it was not registered. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/aae9988880ae14f05609d2dfde56779d64bb3fb1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M runtime/observatory/lib/src/repositories/editor.dart View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
cbernaschina
3 years, 4 months ago (2017-08-11 18:02:22 UTC) #1
siva
lgtm
3 years, 4 months ago (2017-08-14 20:32:42 UTC) #2
cbernaschina
3 years, 4 months ago (2017-08-14 21:37:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
aae9988880ae14f05609d2dfde56779d64bb3fb1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698