Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 3002393002: optimize extension member symbols in DDC, issue #30531 (Closed)

Created:
3 years, 3 months ago by Jennifer Messerly
Modified:
3 years, 3 months ago
Reviewers:
vsm, Leaf
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

optimize extension member symbols in DDC, issue #30531 This approach preserves our current semantics. There's room for further optimizations, though, as it's still not as fast as string names R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/4466c461f0ab748137cd9f873626318fc733f221

Patch Set 1 #

Patch Set 2 : small tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -57 lines) Patch
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View 1 Binary file 0 comments Download
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 1 9 chunks +45 lines, -42 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart View 1 4 chunks +3 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Jennifer Messerly
3 years, 3 months ago (2017-08-25 23:24:07 UTC) #2
Jennifer Messerly
3 years, 3 months ago (2017-08-26 00:26:58 UTC) #5
vsm
lgtm
3 years, 3 months ago (2017-08-26 00:29:58 UTC) #6
Jennifer Messerly
3 years, 3 months ago (2017-08-26 01:36:55 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:10001) manually as
4466c461f0ab748137cd9f873626318fc733f221 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698