Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 3002363002: More pre-publish changes (Closed)

Created:
3 years, 3 months ago by Brian Wilkerson
Modified:
3 years, 3 months ago
Reviewers:
devoncarew, Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M pkg/front_end/pubspec.yaml View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Brian Wilkerson
3 years, 3 months ago (2017-08-25 21:18:04 UTC) #2
devoncarew
lgtm I would suggest sorting the dev dependencies while you're in there - it'll the ...
3 years, 3 months ago (2017-08-25 21:19:54 UTC) #3
Brian Wilkerson
done
3 years, 3 months ago (2017-08-25 21:20:57 UTC) #4
Paul Berry
lgtm
3 years, 3 months ago (2017-08-25 21:22:46 UTC) #5
Brian Wilkerson
3 years, 3 months ago (2017-08-25 21:23:02 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1a1bfa4a9c09bd665672be46154c723cc5f6eb85 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698