Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 3002323002: tweak fasta parser event debug code (Closed)

Created:
3 years, 3 months ago by danrubel
Modified:
3 years, 3 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : address comments #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/diet_listener.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/stack_listener.dart View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
danrubel
3 years, 3 months ago (2017-08-25 15:28:20 UTC) #2
ahe
lgtm https://codereview.chromium.org/3002323002/diff/1/pkg/front_end/lib/src/fasta/source/diet_listener.dart File pkg/front_end/lib/src/fasta/source/diet_listener.dart (right): https://codereview.chromium.org/3002323002/diff/1/pkg/front_end/lib/src/fasta/source/diet_listener.dart#newcode668 pkg/front_end/lib/src/fasta/source/diet_listener.dart:668: // printEvent('DietParser: $name'); I think this should be ...
3 years, 3 months ago (2017-08-28 12:57:42 UTC) #3
danrubel
Committed patchset #3 (id:40001) manually as a816484b5946cd2d00bc601dd3199b9f6286f83f (presubmit successful).
3 years, 3 months ago (2017-08-29 13:10:56 UTC) #5
danrubel
3 years, 3 months ago (2017-08-29 13:19:12 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/3002323002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/source/diet_listener.dart (right):

https://codereview.chromium.org/3002323002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/source/diet_listener.dart:668: //
printEvent('DietParser: $name');
On 2017/08/28 12:57:41, ahe wrote:
> I think this should be "DietListener" instead?

Done.

https://codereview.chromium.org/3002323002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/source/stack_listener.dart (right):

https://codereview.chromium.org/3002323002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/source/stack_listener.dart:120:
print('------------------');
On 2017/08/28 12:57:42, ahe wrote:
> Would you mind adding an extra newline? that is:
> 
> print('------------------\n');

Done.

Powered by Google App Engine
This is Rietveld 408576698