Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 3002303002: Reduce duplicated code (Closed)

Created:
3 years, 3 months ago by Brian Wilkerson
Modified:
3 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -95 lines) Patch
M pkg/analysis_server/lib/src/computer/computer_outline.dart View 19 chunks +23 lines, -36 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart View 2 chunks +2 lines, -57 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 3 months ago (2017-08-25 14:25:28 UTC) #2
scheglov
LGTM
3 years, 3 months ago (2017-08-25 15:09:36 UTC) #3
Brian Wilkerson
3 years, 3 months ago (2017-08-25 15:18:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c38c97def315d24c852a9b67d6d4e3c713057684 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698