Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 30023005: Handle constants in new space on arm by making macro-assembler smarter. (Closed)

Created:
7 years, 2 months ago by titzer
Modified:
7 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Handle constants in new space on arm by making macro-assembler smarter. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17376

Patch Set 1 #

Patch Set 2 : Refresh patch set. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -41 lines) Patch
M src/arm/full-codegen-arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 7 chunks +7 lines, -7 lines 0 comments Download
M src/arm/lithium-gap-resolver-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 1 chunk +0 lines, -11 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 3 chunks +14 lines, -15 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
titzer
7 years, 2 months ago (2013-10-23 14:36:53 UTC) #1
titzer
7 years, 2 months ago (2013-10-24 12:25:09 UTC) #2
Jakob Kummerow
LGTM.
7 years, 2 months ago (2013-10-24 12:37:25 UTC) #3
titzer
7 years, 2 months ago (2013-10-24 12:40:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r17376 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698