Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3002293003: Convert GeneratedContent to async and use AnalysisDriver for tasks graph. (Closed)

Created:
3 years, 3 months ago by scheglov
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Convert GeneratedContent to async and use AnalysisDriver for tasks graph. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/f78d43c3d342ec7223308ee702ceb42b174a97a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -89 lines) Patch
M pkg/analysis_server/tool/spec/check_all_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_dart_protocol.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/codegen_inttest_methods.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_java.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/codegen_java_types.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/codegen_matchers.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/codegen_protocol_constants.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/generate_all.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/to_html.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/tool/summary/check_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analyzer/tool/summary/generate.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/tool/task_dependency_graph/check_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analyzer/tool/task_dependency_graph/generate.dart View 11 chunks +55 lines, -37 lines 0 comments Download
M pkg/analyzer_plugin/tool/spec/check_all_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer_plugin/tool/spec/codegen_dart_protocol.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_plugin/tool/spec/codegen_inttest_methods.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analyzer_plugin/tool/spec/codegen_matchers.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_plugin/tool/spec/codegen_protocol_common.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer_plugin/tool/spec/codegen_protocol_constants.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer_plugin/tool/spec/generate_all.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer_plugin/tool/spec/to_html.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/codegen/tools.dart View 10 chunks +24 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 3 months ago (2017-08-26 01:57:55 UTC) #1
Paul Berry
lgtm
3 years, 3 months ago (2017-08-26 14:44:26 UTC) #2
Brian Wilkerson
lgtm
3 years, 3 months ago (2017-08-26 14:49:50 UTC) #3
scheglov
3 years, 3 months ago (2017-08-26 14:51:40 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
f78d43c3d342ec7223308ee702ceb42b174a97a3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698