Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 3002253002: Use the NavigationCollector from analyzer_plugin to avoid duplication (Closed)

Created:
3 years, 4 months ago by Brian Wilkerson
Modified:
3 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use the NavigationCollector from analyzer_plugin to avoid duplication R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/23bcc17a6195958ee4458e8b3e2475c8a7068de6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -195 lines) Patch
D pkg/analysis_server/lib/plugin/analysis/navigation/navigation_core.dart View 1 chunk +0 lines, -20 lines 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/computer/new_notifications.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 2 chunks +1 line, -1 line 0 comments Download
D pkg/analysis_server/lib/src/domains/analysis/navigation.dart View 1 chunk +0 lines, -92 lines 0 comments Download
M pkg/analysis_server/lib/src/domains/analysis/navigation_dart.dart View 2 chunks +1 line, -1 line 0 comments Download
D pkg/analysis_server/test/analysis/navigation_collector_test.dart View 1 chunk +0 lines, -77 lines 0 comments Download
M pkg/analysis_server/test/analysis/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
This de-duplicates some code that was copied from analysis_server to analyzer_plugin. It does have the ...
3 years, 4 months ago (2017-08-24 19:28:56 UTC) #2
scheglov
LGTM I think it's OK for the server to import from its plugin system.
3 years, 4 months ago (2017-08-24 19:38:12 UTC) #3
Brian Wilkerson
3 years, 3 months ago (2017-08-25 14:25:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
23bcc17a6195958ee4458e8b3e2475c8a7068de6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698