Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: telemetry/telemetry/internal/platform/android_platform_backend.py

Issue 3002243002: [Telemetry] Add --user-data-dir to android_browser_backend.py (Closed)
Patch Set: summary in comment Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « telemetry/telemetry/internal/backends/chrome/android_browser_backend.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/platform/android_platform_backend.py
diff --git a/telemetry/telemetry/internal/platform/android_platform_backend.py b/telemetry/telemetry/internal/platform/android_platform_backend.py
index a7df79b6b80bfbbacd0fe3fc320fe5a719c48e8c..2f12cfe4449377ca0a03fc9d42069b31403baf93 100644
--- a/telemetry/telemetry/internal/platform/android_platform_backend.py
+++ b/telemetry/telemetry/internal/platform/android_platform_backend.py
@@ -606,7 +606,7 @@ class AndroidPlatformBackend(
saved_profile_location = '/sdcard/profile/%s' % profile_base
self._device.PushChangedFiles([(new_profile_dir, saved_profile_location)])
- profile_dir = self._GetProfileDir(package)
+ profile_dir = self.GetProfileDir(package)
self._EfficientDeviceDirectoryCopy(
saved_profile_location, profile_dir)
dumpsys = self._device.RunShellCommand(
@@ -643,7 +643,7 @@ class AndroidPlatformBackend(
profile is to be deleted.
ignore_list: List of files to keep.
"""
- profile_dir = self._GetProfileDir(package)
+ profile_dir = self.GetProfileDir(package)
if not self._device.PathExists(profile_dir):
return
files = [
@@ -662,7 +662,7 @@ class AndroidPlatformBackend(
profile is to be copied.
output_profile_dir: Location where profile to be stored on host machine.
"""
- profile_dir = self._GetProfileDir(package)
+ profile_dir = self.GetProfileDir(package)
logging.info("Pulling profile directory from device: '%s'->'%s'.",
profile_dir, output_profile_path)
# To minimize bandwidth it might be good to look at whether all the data
@@ -688,7 +688,7 @@ class AndroidPlatformBackend(
for filepath in problem_files:
logging.warning('- %s', filepath)
- def _GetProfileDir(self, package):
+ def GetProfileDir(self, package):
"""Returns the on-device location where the application profile is stored
based on Android convention.
« no previous file with comments | « telemetry/telemetry/internal/backends/chrome/android_browser_backend.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698