Add utilities to support the outline notification

Add utilities to support the outline notification

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/efd4051c7ee5c6237f0f176ba7b9077ae45b2fd6

[Brian Wilkerson, 2017-08-24 18:16:04]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-08-24 18:29:21]

LGTM

https://codereview.chromium.org/3002233002/diff/1/pkg/analyzer_plugin/doc/tut...
File pkg/analyzer_plugin/doc/tutorial/outline.md (right):

https://codereview.chromium.org/3002233002/diff/1/pkg/analyzer_plugin/doc/tut...
pkg/analyzer_plugin/doc/tutorial/outline.md:8: Outline information can is
available through a subscription. If the server has
"can" or "is"?

https://codereview.chromium.org/3002233002/diff/1/pkg/analyzer_plugin/doc/tut...
pkg/analyzer_plugin/doc/tutorial/outline.md:9: subscribed for outline
information in some set of files, the the plugin should
"the the" => "then the"?

https://codereview.chromium.org/3002233002/diff/1/pkg/analyzer_plugin/test/pl...
File pkg/analyzer_plugin/test/plugin/outline_mixin_test.dart (right):

https://codereview.chromium.org/3002233002/diff/1/pkg/analyzer_plugin/test/pl...
pkg/analyzer_plugin/test/plugin/outline_mixin_test.dart:61: await
plugin.sendOutlineNotification(filePath1);
We don't actually verify that onNotification is invoked.

[Brian Wilkerson, 2017-08-24 18:52:47]

I've updated the test, but would appreciate another look to make sure what I've
done is reasonable.

If so, I'm also going to fix the similar test for navigation notifications in
the same way as part of this CL.

https://codereview.chromium.org/3002233002/diff/1/pkg/analyzer_plugin/doc/tut...
File pkg/analyzer_plugin/doc/tutorial/outline.md (right):

https://codereview.chromium.org/3002233002/diff/1/pkg/analyzer_plugin/doc/tut...
pkg/analyzer_plugin/doc/tutorial/outline.md:8: Outline information can is
available through a subscription. If the server has
Done ('is')

https://codereview.chromium.org/3002233002/diff/1/pkg/analyzer_plugin/doc/tut...
pkg/analyzer_plugin/doc/tutorial/outline.md:9: subscribed for outline
information in some set of files, the the plugin should
Done

https://codereview.chromium.org/3002233002/diff/1/pkg/analyzer_plugin/test/pl...
File pkg/analyzer_plugin/test/plugin/outline_mixin_test.dart (right):

https://codereview.chromium.org/3002233002/diff/1/pkg/analyzer_plugin/test/pl...
pkg/analyzer_plugin/test/plugin/outline_mixin_test.dart:61: await
plugin.sendOutlineNotification(filePath1);
Good catch!

[scheglov, 2017-08-24 18:57:39]

LGTM

[Brian Wilkerson, 2017-08-24 18:59:09]

Description was changed from

==========
Add utilities to support the outline notification
==========

to

==========
Add utilities to support the outline notification

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/efd4051c7ee5c6237f0f176ba7b9077ae45b2fd6
==========

[Brian Wilkerson, 2017-08-24 18:59:10]

Committed patchset #2 (id:20001) manually as
efd4051c7ee5c6237f0f176ba7b9077ae45b2fd6 (presubmit successful).