- Add possibility to redirect messages if they were not delivered.

- Add possibility to redirect messages if they were not delivered.
- Prepare OOB handling for more than service messages.
- Do not use growable arrays when growing is not necessary.

R=johnmccutchan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=36772

[Ivan Posva, 2014-05-28 21:02:31]

https://codereview.chromium.org/300223011/diff/1/runtime/vm/message.h
File runtime/vm/message.h (right):

https://codereview.chromium.org/300223011/diff/1/runtime/vm/message.h#newcode45
runtime/vm/message.h:45: Dart_Port delivery_failure_port = kIllegalPort)
The setting of this value is not hooked up yet. The API changes for this will be
in a separate CL.

[Cutch, 2014-05-28 21:29:02]

lgtm with comment

https://codereview.chromium.org/300223011/diff/1/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/300223011/diff/1/runtime/vm/isolate.cc#newcod...
runtime/vm/isolate.cc:178: UNREACHABLE();
Should the RedirectToDeliveryFailurePort get a chance to handle an OOB message
not handled in this switch statement?

[Cutch, 2014-05-28 21:29:02]

lgtm with comment

https://codereview.chromium.org/300223011/diff/1/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/300223011/diff/1/runtime/vm/isolate.cc#newcod...
runtime/vm/isolate.cc:178: UNREACHABLE();
Should the RedirectToDeliveryFailurePort get a chance to handle an OOB message
not handled in this switch statement?

[Ivan Posva, 2014-05-28 21:39:42]

Thanks.

-Ivan

https://codereview.chromium.org/300223011/diff/1/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/300223011/diff/1/runtime/vm/isolate.cc#newcod...
runtime/vm/isolate.cc:178: UNREACHABLE();
On 2014/05/28 21:29:03, Cutch wrote:
> Should the RedirectToDeliveryFailurePort get a chance to handle an OOB message
> not handled in this switch statement?

OOB should never have a redirect port associated with it. Maybe we should make
it is that way when creating/enqueueing the message.

[Ivan Posva, 2014-05-28 21:58:45]

Committed patchset #2 manually as r36772 (presubmit successful).