Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 300223008: Add module annotation to specify the name of the java class for constants. (Closed)

Created:
6 years, 7 months ago by qsr
Modified:
6 years, 6 months ago
Reviewers:
viettrungluu, rmcilroy
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Add module annotation to specify the name of the java class for constants. R=rmcilroy@chromium.org, viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274526

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove expression #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -10 lines) Patch
M mojo/android/javatests/src/org/chromium/mojo/bindings/BindingsTest.java View 1 2 chunks +12 lines, -4 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/sample_interfaces.mojom View 1 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_java_generator.py View 1 2 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
qsr
6 years, 7 months ago (2014-05-28 09:40:42 UTC) #1
rmcilroy
nice, lgtm - thanks. https://codereview.chromium.org/300223008/diff/1/mojo/public/interfaces/bindings/tests/sample_interfaces.mojom File mojo/public/interfaces/bindings/tests/sample_interfaces.mojom (right): https://codereview.chromium.org/300223008/diff/1/mojo/public/interfaces/bindings/tests/sample_interfaces.mojom#newcode10 mojo/public/interfaces/bindings/tests/sample_interfaces.mojom:10: const uint64 kLong = (879+2)*5; ...
6 years, 6 months ago (2014-05-28 17:03:30 UTC) #2
viettrungluu
lgtm https://codereview.chromium.org/300223008/diff/1/mojo/public/interfaces/bindings/tests/sample_interfaces.mojom File mojo/public/interfaces/bindings/tests/sample_interfaces.mojom (right): https://codereview.chromium.org/300223008/diff/1/mojo/public/interfaces/bindings/tests/sample_interfaces.mojom#newcode10 mojo/public/interfaces/bindings/tests/sample_interfaces.mojom:10: const uint64 kLong = (879+2)*5; On 2014/05/28 17:03:30, ...
6 years, 6 months ago (2014-05-28 19:10:26 UTC) #3
qsr
The CQ bit was checked by qsr@chromium.org
6 years, 6 months ago (2014-06-03 08:58:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/300223008/20001
6 years, 6 months ago (2014-06-03 09:00:56 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-03 12:42:12 UTC) #6
qsr
6 years, 6 months ago (2014-06-03 14:54:23 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r274526 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698