Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Unified Diff: net/quic/test_tools/crypto_test_utils.h

Issue 300223007: Break ChannelIDSigner into two classes: ChannelIDKey and ChannelIDSource. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes build on C++03 Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/crypto/quic_crypto_client_config.cc ('k') | net/quic/test_tools/crypto_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/test_tools/crypto_test_utils.h
diff --git a/net/quic/test_tools/crypto_test_utils.h b/net/quic/test_tools/crypto_test_utils.h
index 60c2a57f2a738970a6aeded94bc1b7dc0d50cb89..b03575fc5b40af7f7601722c3364e3503a9836b0 100644
--- a/net/quic/test_tools/crypto_test_utils.h
+++ b/net/quic/test_tools/crypto_test_utils.h
@@ -19,7 +19,7 @@
namespace net {
-class ChannelIDSigner;
+class ChannelIDSource;
class CommonCertSets;
class ProofSource;
class ProofVerifier;
@@ -48,8 +48,7 @@ class CryptoTestUtils {
bool dont_verify_certs;
// If channel_id_enabled is true then the client will attempt to send a
- // ChannelID. The key will be the same as is returned by
- // ChannelIDSigner's |GetKeyForHostname|.
+ // ChannelID.
bool channel_id_enabled;
};
@@ -133,9 +132,9 @@ class CryptoTestUtils {
static CryptoHandshakeMessage BuildMessage(const char* message_tag,
va_list ap);
- // ChannelIDSignerForTesting returns a ChannelIDSigner that generates keys
- // deterministically based on the hostname given in the Sign call.
- static ChannelIDSigner* ChannelIDSignerForTesting();
+ // ChannelIDSourceForTesting returns a ChannelIDSource that generates keys
+ // deterministically based on the hostname given in the GetChannelID call.
+ static ChannelIDSource* ChannelIDSourceForTesting();
private:
static void CompareClientAndServerKeys(QuicCryptoClientStream* client,
« no previous file with comments | « net/quic/crypto/quic_crypto_client_config.cc ('k') | net/quic/test_tools/crypto_test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698