Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 3002133002: Fix DDC presubmit status. (Closed)

Created:
3 years, 3 months ago by Leaf
Modified:
3 years, 3 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix DDC presubmit status. Update some status entries and fix a few miscellaneous issues. BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/f744dea741461f80e683ace646cfd73269e4b511

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M pkg/dev_compiler/test/browser/language_tests.js View 6 chunks +11 lines, -3 lines 0 comments Download
M pkg/dev_compiler/test/browser/runtime_tests.js View 1 chunk +7 lines, -4 lines 0 comments Download
M tests/lib_strong/async/catch_errors.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Leaf
3 years, 3 months ago (2017-08-22 23:19:40 UTC) #2
Jennifer Messerly
lgtm, thanks so much!
3 years, 3 months ago (2017-08-22 23:24:09 UTC) #3
Leaf
3 years, 3 months ago (2017-08-22 23:29:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f744dea741461f80e683ace646cfd73269e4b511 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698