Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(962)

Issue 3002013002: Fix initialization of instance fields. (Closed)

Created:
3 years, 4 months ago by zhivkag
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add test with instance and static fields. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1 line) Patch
M pkg/kernel/lib/interpreter/interpreter.dart View 1 chunk +1 line, -1 line 0 comments Download
A pkg/kernel/testcases/interpreter/instance_and_static_fields_test.dart View 1 1 chunk +29 lines, -0 lines 0 comments Download
A pkg/kernel/testcases/interpreter/instance_and_static_fields_test.dart.expect View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zhivkag
3 years, 4 months ago (2017-08-21 09:15:52 UTC) #2
Dmitry Stefantsov
https://codereview.chromium.org/3002013002/diff/1/pkg/kernel/testcases/interpreter/object_field_initializers_test.dart File pkg/kernel/testcases/interpreter/object_field_initializers_test.dart (right): https://codereview.chromium.org/3002013002/diff/1/pkg/kernel/testcases/interpreter/object_field_initializers_test.dart#newcode63 pkg/kernel/testcases/interpreter/object_field_initializers_test.dart:63: static String staticFoo = 'foo'; Looks like this update ...
3 years, 4 months ago (2017-08-21 09:40:33 UTC) #3
zhivkag
We expect that adding a static field would not change how objects are initialized, however ...
3 years, 4 months ago (2017-08-21 10:20:16 UTC) #4
Dmitry Stefantsov
LGTM
3 years, 4 months ago (2017-08-21 10:24:47 UTC) #5
zhivkag
3 years, 4 months ago (2017-08-21 16:54:43 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c237e6dbcd4550bd889a2d75fbd7a7f7d4572270 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698