Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 3002003002: Add support for catch statements. (Closed)

Created:
3 years, 4 months ago by zhivkag
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove formatting changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -12 lines) Patch
M pkg/kernel/lib/interpreter/interpreter.dart View 1 3 chunks +33 lines, -6 lines 0 comments Download
M pkg/kernel/testcases/interpreter/try_catch_finally_test.dart View 3 chunks +20 lines, -4 lines 0 comments Download
M pkg/kernel/testcases/interpreter/try_catch_finally_test.dart.expect View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
zhivkag
This change adds support for catch statements that have a guard of type dynamic.
3 years, 4 months ago (2017-08-21 09:15:58 UTC) #2
Dmitry Stefantsov
LGTM
3 years, 4 months ago (2017-08-21 10:39:17 UTC) #3
ashlaura02
lgtm
3 years, 4 months ago (2017-08-21 13:27:07 UTC) #5
zhivkag
3 years, 3 months ago (2017-08-25 11:54:12 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
984382b64ef0da7ec1944bee8953eda1651a195b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698