Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Unified Diff: pkg/analyzer/lib/src/fasta/ast_builder.dart

Issue 3001993002: improve fasta export directive recovery (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/fasta/ast_builder.dart
diff --git a/pkg/analyzer/lib/src/fasta/ast_builder.dart b/pkg/analyzer/lib/src/fasta/ast_builder.dart
index 7580511ad0e7d1d44dadacb5129acc57205adbaa..80dd6fa415e4b7a3e3f1732b4148ac7759b06e9d 100644
--- a/pkg/analyzer/lib/src/fasta/ast_builder.dart
+++ b/pkg/analyzer/lib/src/fasta/ast_builder.dart
@@ -1138,6 +1138,7 @@ class AstBuilder extends ScopeListener {
@override
void beginCompilationUnit(Token token) {
+ super.beginCompilationUnit(token);
push(token);
}
@@ -1896,15 +1897,20 @@ class AstBuilder extends ScopeListener {
ParserErrorCode.EXPECTED_STRING_LITERAL, charOffset, 1);
return;
case "UNEXPECTED_TOKEN":
- var text = arguments['string'];
+ String text = arguments['string'];
if (text == null) {
Token token = arguments['token'];
if (token != null) {
text = token.lexeme;
}
}
- errorReporter?.reportErrorForOffset(
- ParserErrorCode.UNEXPECTED_TOKEN, charOffset, 1, [text]);
+ if (text == ';') {
+ errorReporter?.reportErrorForOffset(
+ ParserErrorCode.EXPECTED_TOKEN, charOffset, text.length, [text]);
+ } else {
+ errorReporter?.reportErrorForOffset(
+ ParserErrorCode.UNEXPECTED_TOKEN, charOffset, 1, [text]);
+ }
return;
default:
// fall through
« no previous file with comments | « no previous file | pkg/analyzer/test/generated/parser_fasta_listener.dart » ('j') | pkg/front_end/lib/src/fasta/parser/parser.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698