Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Unified Diff: tracing/tracing/value/ui/diagnostic_span.html

Issue 3001953002: Linkify sample Breakdowns via RelatedHistogramBreakdowns. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/value/ui/breakdown_span_test.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/value/ui/diagnostic_span.html
diff --git a/tracing/tracing/value/ui/diagnostic_span.html b/tracing/tracing/value/ui/diagnostic_span.html
index 395b95e61390ae26a00ecef68b094550f4e95f15..ce3c31a3f18e448daa51b5385cbe3c6f9282f28a 100644
--- a/tracing/tracing/value/ui/diagnostic_span.html
+++ b/tracing/tracing/value/ui/diagnostic_span.html
@@ -67,7 +67,9 @@ tr.exportTo('tr.v.ui', function() {
function createDiagnosticSpan(diagnostic, name, histogram) {
const tagName = findElementNameForDiagnostic(diagnostic);
const span = document.createElement(tagName);
- if (span.build === undefined) throw new Error(tagName);
+ if (span.build === undefined) {
+ throw new Error(`Invalid diagnostic span "${tagName}"`);
+ }
span.build(diagnostic, name, histogram);
return span;
}
« no previous file with comments | « tracing/tracing/value/ui/breakdown_span_test.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698