Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3001953002: Linkify sample Breakdowns via RelatedHistogramBreakdowns. (Closed)

Created:
3 years, 4 months ago by benjhayden
Modified:
3 years, 3 months ago
Reviewers:
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Linkify sample Breakdowns via RelatedHistogramBreakdowns. XXX BEFORE PUBLISHING: - sample results.html - refactor Currently, breakdown-span displays information from either a RelatedHistogramBreakdown or a Breakdown at a time. RHBs are just maps of related histograms; breakdown-span displays their totals. Breakdowns are maps of numbers. RHBs are histogram diagnostics; Breakdowns are sample diagnostics. RHBs contain the coarse histogram-level structure; Breakdowns contain the fine-grained sample-level structure. breakdown-spans for RHBs contain clickable links; breakdown-spans for Breakdowns do not. This CL makes breakdown-spans for Breakdowns look for corresponding RHBs so that breakdown-spans for Breakdowns contain clickable links. This unifies the fine-grained numbers from Breakdowns with the clickable links from RHBS. Some metrics currently use RHBs, some use Breakdowns, none use both. All metrics should use both.

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -11 lines) Patch
M tracing/tracing/value/ui/breakdown_span.html View 4 chunks +27 lines, -10 lines 0 comments Download
M tracing/tracing/value/ui/breakdown_span_test.html View 1 chunk +57 lines, -0 lines 0 comments Download
M tracing/tracing/value/ui/diagnostic_span.html View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (5 generated)
benjhayden
Patchset #1 (id:1) has been deleted
3 years, 4 months ago (2017-08-18 17:02:39 UTC) #1
benjhayden
Patchset #1 (id:20001) has been deleted
3 years, 4 months ago (2017-08-21 15:23:44 UTC) #2
benjhayden
Patchset #1 (id:40001) has been deleted
3 years, 4 months ago (2017-08-21 15:23:49 UTC) #3
benjhayden
Patchset #1 (id:60001) has been deleted
3 years, 4 months ago (2017-08-21 16:55:50 UTC) #4
benjhayden
3 years, 4 months ago (2017-08-22 05:14:10 UTC) #5 
Description was changed from

==========
Linkify sample Breakdowns via RelatedHistogramBreakdowns.
==========

to

==========
Linkify sample Breakdowns via RelatedHistogramBreakdowns.

XXX BEFORE PUBLISHING:
- sample results.html
- refactor

Currently, breakdown-span displays information from either a
RelatedHistogramBreakdown or a Breakdown at a time.
RHBs are just maps of related histograms; breakdown-span displays their totals.
Breakdowns are maps of numbers.
RHBs are histogram diagnostics; Breakdowns are sample diagnostics.
RHBs contain the coarse histogram-level structure; Breakdowns contain the
fine-grained sample-level structure.
breakdown-spans for RHBs contain clickable links;
breakdown-spans for Breakdowns do not.

This CL makes breakdown-spans for Breakdowns look for corresponding RHBs so that
breakdown-spans for Breakdowns contain clickable links.
This unifies the fine-grained numbers from Breakdowns with the clickable links
from RHBS.

Some metrics currently use RHBs, some use Breakdowns, none use both.
All metrics should use both.
==========

Powered by Google App Engine
This is Rietveld 408576698