Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1032)

Issue 3001923002: [telemetry_mini] Fix bug in actions.ClearRecentApps (Closed)

Created:
3 years, 4 months ago by perezju
Modified:
3 years, 4 months ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[telemetry_mini] Fix bug in actions.ClearRecentApps Sometimes we need to swipe down several times until the "Clear All" button becomes visible. BUG=chromium:752963 Review-Url: https://codereview.chromium.org/3001923002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/67520e6add0372b9e025a8b2fc639fbcd13caa90

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -17 lines) Patch
M experimental/telemetry_mini/telemetry_mini.py View 6 chunks +23 lines, -17 lines 1 comment Download

Depends on Patchset:

Messages

Total messages: 10 (4 generated)
perezju
3 years, 4 months ago (2017-08-18 13:55:18 UTC) #2
nednguyen
lgtm
3 years, 4 months ago (2017-08-18 13:56:09 UTC) #3
nednguyen
https://codereview.chromium.org/3001923002/diff/1/experimental/telemetry_mini/telemetry_mini.py File experimental/telemetry_mini/telemetry_mini.py (right): https://codereview.chromium.org/3001923002/diff/1/experimental/telemetry_mini/telemetry_mini.py#newcode294 experimental/telemetry_mini/telemetry_mini.py:294: for _ in xrange(5): I am surprised that there ...
3 years, 4 months ago (2017-08-18 14:02:18 UTC) #4
perezju
On 2017/08/18 14:02:18, nednguyen wrote: > https://codereview.chromium.org/3001923002/diff/1/experimental/telemetry_mini/telemetry_mini.py > File experimental/telemetry_mini/telemetry_mini.py (right): > > https://codereview.chromium.org/3001923002/diff/1/experimental/telemetry_mini/telemetry_mini.py#newcode294 > ...
3 years, 4 months ago (2017-08-18 14:10:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3001923002/1
3 years, 4 months ago (2017-08-18 14:37:12 UTC) #7
commit-bot: I haz the power
3 years, 4 months ago (2017-08-18 15:04:08 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698