[vm] Read interface_target_reference from kernel binaries

[vm] Read interface_target_reference from kernel binaries

This CL adds reading of 'interface_target_reference' from kernel
binary files and storing it in InstanceCallInstr IL instructions.
Later, it will be used to generate better code in AOT (in strong mode).

R=rmacnak@google.com

Issue: https://github.com/dart-lang/sdk/issues/30480
Committed: https://github.com/dart-lang/sdk/commit/61ba2f1e9a2f9f828828c0484391a01f947a1745

[alexmarkov, 2017-08-18 00:29:45]

alexmarkov@google.com changed reviewers:
+ asiva@google.com, kmillikin@google.com, rmacnak@google.com, vegorov@google.com

[rmacnak, 2017-08-18 00:52:43]

lgtm w/c

https://codereview.chromium.org/3001883002/diff/1/runtime/vm/flag_list.h
File runtime/vm/flag_list.h (right):

https://codereview.chromium.org/3001883002/diff/1/runtime/vm/flag_list.h#newc...
runtime/vm/flag_list.h:80: P(experimental_strong_mode, bool, false, "Enable
experimental strong mode.") \
Siva, wasn't there some common flag all the implementations were meant to
introduce? Dart 2 preview or such?

https://codereview.chromium.org/3001883002/diff/1/runtime/vm/intermediate_lan...
File runtime/vm/intermediate_language.h (right):

https://codereview.chromium.org/3001883002/diff/1/runtime/vm/intermediate_lan...
runtime/vm/intermediate_language.h:2880:
ASSERT(function_name.IsNotTemporaryScopedHandle());
ASSERT(interface_target_.IsNotTemporaryScopedHandle());

[siva, 2017-08-18 01:09:01]

https://codereview.chromium.org/3001883002/diff/1/runtime/vm/flag_list.h
File runtime/vm/flag_list.h (right):

https://codereview.chromium.org/3001883002/diff/1/runtime/vm/flag_list.h#newc...
runtime/vm/flag_list.h:80: P(experimental_strong_mode, bool, false, "Enable
experimental strong mode.") \
On 2017/08/18 00:52:43, rmacnak wrote:
> Siva, wasn't there some common flag all the implementations were meant to
> introduce? Dart 2 preview or such?

Yes preview_dart_2 but that would also include a whole slew of other stuff like
turning on the Dart front end, kernel etc.

Maybe for now we can keep this under an experimental flag and when things
stabilize include it under preview_dart_2.

[alexmarkov, 2017-08-18 17:15:57]

https://codereview.chromium.org/3001883002/diff/1/runtime/vm/intermediate_lan...
File runtime/vm/intermediate_language.h (right):

https://codereview.chromium.org/3001883002/diff/1/runtime/vm/intermediate_lan...
runtime/vm/intermediate_language.h:2880:
ASSERT(function_name.IsNotTemporaryScopedHandle());
On 2017/08/18 00:52:43, rmacnak wrote:
> ASSERT(interface_target_.IsNotTemporaryScopedHandle());

Done.

[alexmarkov, 2017-08-18 17:23:14]

Description was changed from

==========
[vm] Read interface_target_reference from kernel binaries

This CL adds reading of 'interface_target_reference' from kernel
binary files and storing it in InstanceCallInstr IL instructions.
Later, it will be used to generate better code in AOT (in strong mode).

Issue: https://github.com/dart-lang/sdk/issues/30480
==========

to

==========
[vm] Read interface_target_reference from kernel binaries

This CL adds reading of 'interface_target_reference' from kernel
binary files and storing it in InstanceCallInstr IL instructions.
Later, it will be used to generate better code in AOT (in strong mode).

R=rmacnak@google.com

Issue: https://github.com/dart-lang/sdk/issues/30480
Committed:
https://github.com/dart-lang/sdk/commit/61ba2f1e9a2f9f828828c0484391a01f947a1745
==========

[alexmarkov, 2017-08-18 17:23:15]

Committed patchset #2 (id:20001) manually as
61ba2f1e9a2f9f828828c0484391a01f947a1745 (presubmit successful).