[Telemetry] Add CanRunOnPlatform to story_runner and benchmark class.

telemetry/telemetry/internal/story_runner_unittest.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import json
 import math
 import os
 import shutil
 import StringIO
 import sys
@@ skipping 1234 matching lines @@
     options.results_label = None
     options.reset_results = False
     options.use_live_sites = False
     options.max_failures = 100
     options.pause = None
     options.pageset_repeat = 1
     options.output_formats = ['chartjson']
     options.run_disabled_tests = False
     return options
 
+  def testRunBenchmarkDisabledBenchmarkViaCanRunonPlatform(self):
+    fake_benchmark = FakeBenchmark()
+    fake_benchmark.SUPPORTED_PLATFORMS = []
+    options = self._GenerateBaseBrowserFinderOptions()
+    tmp_path = tempfile.mkdtemp()
+    try:
+      options.output_dir = tmp_path
+      story_runner.RunBenchmark(fake_benchmark, options)
+      with open(os.path.join(tmp_path, 'results-chart.json')) as f:
+        data = json.load(f)
+      self.assertFalse(data['enabled'])
+    finally:
+      shutil.rmtree(tmp_path)
+
+  # TODO(rnephew): Remove this test when we no longer use

[charliea (OOO until 10-5), 2017/08/22 17:22:18]

Won't "PermanentlyDisableBenchmark" just become "TemporarilyDisableBenchmark"
(or possibly "DisableBenchmark") though?

[rnephew (Reviews Here), 2017/08/22 17:33:20]

Reworded to Refactor instead of Remove.

+  # expectations.PermanentlyDisableBenchmark() to disable benchmarks.
   def testRunBenchmarkDisabledBenchmark(self):
     fake_benchmark = FakeBenchmark()
     fake_benchmark.disabled = True
     options = self._GenerateBaseBrowserFinderOptions()
     tmp_path = tempfile.mkdtemp()
     try:
       options.output_dir = tmp_path
       story_runner.RunBenchmark(fake_benchmark, options)
       with open(os.path.join(tmp_path, 'results-chart.json')) as f:
         data = json.load(f)
       self.assertFalse(data['enabled'])
     finally:
       shutil.rmtree(tmp_path)
 
+  # TODO(rnephew): Remove this test when we no longer use
+  # expectations.PermanentlyDisableBenchmark() to disable benchmarks.
   def testRunBenchmarkDisabledBenchmarkCannotOverriddenByCommandLine(self):
     fake_benchmark = FakeBenchmark()
     fake_benchmark.disabled = True
     options = self._GenerateBaseBrowserFinderOptions()
     options.run_disabled_tests = True
     temp_path = tempfile.mkdtemp()
     try:
       options.output_dir = temp_path
       story_runner.RunBenchmark(fake_benchmark, options)
       with open(os.path.join(temp_path, 'results-chart.json')) as f:
@@ skipping 106 matching lines @@
     fake_benchmark.story_disabled = True
     options = self._GenerateBaseBrowserFinderOptions()
     tmp_path = tempfile.mkdtemp()
     try:
       options.output_dir = tmp_path
       rc = story_runner.RunBenchmark(fake_benchmark, options)
       # Test should return 0 since only error messages are logged.
       self.assertEqual(rc, 0)
     finally:
       shutil.rmtree(tmp_path)