[Telemetry] Add CanRunOnPlatform to story_runner and benchmark class.

telemetry/telemetry/benchmark.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import optparse
 
 from py_utils import class_util
 from telemetry import decorators
 from telemetry.internal import story_runner
 from telemetry.internal.util import command_line
@@ skipping 45 matching lines @@
 
   A benchmark packages a measurement and a PageSet together.
   Benchmarks default to using TBM unless you override the value of
   Benchmark.test, or override the CreatePageTest method.
 
   New benchmarks should override CreateStorySet.
   """
   options = {}
   page_set = None
   test = timeline_based_measurement.TimelineBasedMeasurement
+  SUPPORTED_PLATFORMS = [expectations.ALL]
 
   def __init__(self, max_failures=None):
     """Creates a new Benchmark.
 
     Args:
       max_failures: The number of story run's failures before bailing
           from executing subsequent page runs. If None, we never bail.
     """
     self._expectations = None
     self._max_failures = max_failures
     # TODO: There should be an assertion here that checks that only one of
     # the following is true:
     # * It's a TBM benchmark, with CreateCoreTimelineBasedMeasurementOptions
     #   defined.
     # * It's a legacy benchmark, with either CreatePageTest defined or
     #   Benchmark.test set.
     # See https://github.com/catapult-project/catapult/issues/3708
 
 
+  def CanRunOnPlatform(self, platform, finder_options):

[nednguyen, 2017/08/18 23:46:53]

If this is not supposed to be overridden, can you rename it with
_CanRunPlatform?

[rnephew (Reviews Here), 2017/08/21 16:30:32]

Done.

+    for p in self.SUPPORTED_PLATFORMS:
+      # This is reusing StoryExpectation code, so it is a bit unintuitive. We
+      # are trying to detect the opposite of the usual case in StoryExpectations
+      # so we want to return True when ShouldDisable returns true, even though
+      # we do not want to disable.
+      if p.ShouldDisable(platform, finder_options):
+        return True
+    return False
+
   # pylint: disable=unused-argument
   @classmethod
   def ShouldDisable(cls, possible_browser):
     """Override this method to disable a benchmark under specific conditions.
 
      Supports logic too complex for simple Enabled and Disabled decorators.
      Decorators are still respected in cases where this function returns False.
      """
     return False
 
@@ skipping 252 matching lines @@
     """
     return expectations.StoryExpectations()
 
 
 def AddCommandLineArgs(parser):
   story_runner.AddCommandLineArgs(parser)
 
 
 def ProcessCommandLineArgs(parser, args):
   story_runner.ProcessCommandLineArgs(parser, args)