Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 3001823002: Revert "Various redemptions" (Closed)

Created:
3 years, 4 months ago by Johnni Winther
Modified:
3 years, 4 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org, Emily Fortuna
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Various redemptions" This reverts commit 49b064da419f6eb141c980aec15296a4bb517956. Committed: https://github.com/dart-lang/sdk/commit/a0110b32f33462be85db64cbda2024ee8912a968

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -108 lines) Patch
M pkg/compiler/lib/src/common_elements.dart View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/collector.dart View 3 chunks +6 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart View 5 chunks +8 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 11 chunks +43 lines, -46 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/registry.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/type_test_registry.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_model/closure.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 2 chunks +0 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/kernel/env.dart View 2 chunks +0 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_strategy.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
TBR
3 years, 4 months ago (2017-08-17 08:52:15 UTC) #2
Johnni Winther
Committed patchset #1 (id:1) manually as a0110b32f33462be85db64cbda2024ee8912a968 (presubmit successful).
3 years, 4 months ago (2017-08-17 08:52:45 UTC) #4
ahe
3 years, 4 months ago (2017-08-17 09:21:32 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698