Migrate block 114 (and some of 113).

Migrate block 114 (and some of 113).

generic_instanceof ... getter_closure_execution_order_test.

The main interesting one is generic_methods_type_expression_test. It
was testing old Dart 1.0-specific behavior and needed a lot of changes.

R=jmesserly@google.com

Committed: https://github.com/dart-lang/sdk/commit/615be6451e6e84820e52126e9167f0b21b23c493

[Bob Nystrom, 2017-08-17 02:02:08]

rnystrom@google.com changed reviewers:
+ bkonyi@google.com, jmesserly@google.com

[Jennifer Messerly, 2017-08-17 06:22:46]

ooh nice! a few Q's

https://codereview.chromium.org/3001803002/diff/1/tests/language_2/generic_me...
File tests/language_2/generic_methods_type_expression_test.dart (right):

https://codereview.chromium.org/3001803002/diff/1/tests/language_2/generic_me...
tests/language_2/generic_methods_type_expression_test.dart:54:
Expect.equals(f8<int>(), new TypeValue<List<int>>().value); // Returns
`List<int>`.
long line

https://codereview.chromium.org/3001803002/diff/1/tests/language_2/language_2...
File tests/language_2/language_2.status (right):

https://codereview.chromium.org/3001803002/diff/1/tests/language_2/language_2...
tests/language_2/language_2.status:34: generic_list_checked_test: Skip
why are these skipped?

https://codereview.chromium.org/3001803002/diff/1/tests/language_2/language_2...
File tests/language_2/language_2_analyzer.status (right):

https://codereview.chromium.org/3001803002/diff/1/tests/language_2/language_2...
tests/language_2/language_2_analyzer.status:240:
generic_methods_type_expression_test: StaticWarning # Incorrectly disallows type
parameter in "is" test.
is/should there be a bug filed for this?

https://codereview.chromium.org/3001803002/diff/1/tests/language_2/language_2...
tests/language_2/language_2_analyzer.status:252: generic_methods_shadowing_test:
CompileTimeError # Issue 29070
all the associated bugs have been closed ... is this still a product issue, or
is a test issue? do we need to reopen or file new bugs?

https://codereview.chromium.org/3001803002/diff/1/tests/language_2/language_2...
File tests/language_2/language_2_dartdevc.status (right):

https://codereview.chromium.org/3001803002/diff/1/tests/language_2/language_2...
tests/language_2/language_2_dartdevc.status:24: generic_local_functions_test:
CompileTimeError
some of these might duplicates with Analyzer issues, but I'm curious why these
don't compile?

https://codereview.chromium.org/3001803002/diff/1/tests/language_2/language_2...
tests/language_2/language_2_dartdevc.status:25: generic_method_types_test/01:
RuntimeError
these should be in the $runtime != none section

https://codereview.chromium.org/3001803002/diff/1/tests/language_2/language_2...
tests/language_2/language_2_dartdevc.status:65: generic_instanceof_test:
RuntimeError # Issue 29920
is this a DDC or test issue? often these are strong mode runtime failures

FYI:

$ pkg/dev_compiler/tool/ddc <entry_point>

is a quick way to run stuff on node


$ pkg/dev_compiler/tool/ddw <entry_point>

is a quick way to debug stuff using devtool

https://codereview.chromium.org/3001803002/diff/1/tests/language_2/language_2...
File tests/language_2/language_2_kernel.status (right):

https://codereview.chromium.org/3001803002/diff/1/tests/language_2/language_2...
tests/language_2/language_2_kernel.status:20: generic_methods_bounds_test/none:
Pass
do the "Pass" lines need to be included?

[bkonyi, 2017-08-22 08:09:29]

https://codereview.chromium.org/3001803002/diff/1/tests/language_2/language_2...
File tests/language_2/language_2.status (right):

https://codereview.chromium.org/3001803002/diff/1/tests/language_2/language_2...
tests/language_2/language_2.status:34: generic_list_checked_test: Skip
On 2017/08/17 06:22:45, Jennifer Messerly wrote:
> why are these skipped?

This section should be removed and the tests made strong mode clean.

https://codereview.chromium.org/3001803002/diff/1/tests/language_2/language_2...
File tests/language_2/language_2_kernel.status (right):

https://codereview.chromium.org/3001803002/diff/1/tests/language_2/language_2...
tests/language_2/language_2_kernel.status:20: generic_methods_bounds_test/none:
Pass
On 2017/08/17 06:22:45, Jennifer Messerly wrote:
> do the "Pass" lines need to be included?

My guess is that these tests are expected to fail elsewhere, and passing is the
exception? Generally there's not 'Pass' entries unless they're needed for some
special case.

[Bob Nystrom, 2017-08-24 01:00:27]

Thanks!

https://codereview.chromium.org/3001803002/diff/1/tests/language_2/generic_me...
File tests/language_2/generic_methods_type_expression_test.dart (right):

https://codereview.chromium.org/3001803002/diff/1/tests/language_2/generic_me...
tests/language_2/generic_methods_type_expression_test.dart:54:
Expect.equals(f8<int>(), new TypeValue<List<int>>().value); // Returns
`List<int>`.
On 2017/08/17 06:22:45, Jennifer Messerly wrote:
> long line

Done.

https://codereview.chromium.org/3001803002/diff/1/tests/language_2/language_2...
File tests/language_2/language_2.status (right):

https://codereview.chromium.org/3001803002/diff/1/tests/language_2/language_2...
tests/language_2/language_2.status:34: generic_list_checked_test: Skip
On 2017/08/22 08:09:29, bkonyi wrote:
> On 2017/08/17 06:22:45, Jennifer Messerly wrote:
> > why are these skipped?
> 
> This section should be removed and the tests made strong mode clean.

Ben's right. This was a mistake on my part. Fixed!

https://codereview.chromium.org/3001803002/diff/1/tests/language_2/language_2...
File tests/language_2/language_2_analyzer.status (right):

https://codereview.chromium.org/3001803002/diff/1/tests/language_2/language_2...
tests/language_2/language_2_analyzer.status:240:
generic_methods_type_expression_test: StaticWarning # Incorrectly disallows type
parameter in "is" test.
On 2017/08/17 06:22:45, Jennifer Messerly wrote:
> is/should there be a bug filed for this?

Done.

https://codereview.chromium.org/3001803002/diff/1/tests/language_2/language_2...
tests/language_2/language_2_analyzer.status:252: generic_methods_shadowing_test:
CompileTimeError # Issue 29070
On 2017/08/17 06:22:45, Jennifer Messerly wrote:
> all the associated bugs have been closed ... is this still a product issue, or
> is a test issue? do we need to reopen or file new bugs?

I don't know. Most of these statuses get copied over automatically from the
original status files with the comments intact. We generally haven't been filing
new tracking bugs for stuff, mainly to try to not slow us down.

https://codereview.chromium.org/3001803002/diff/1/tests/language_2/language_2...
File tests/language_2/language_2_dartdevc.status (right):

https://codereview.chromium.org/3001803002/diff/1/tests/language_2/language_2...
tests/language_2/language_2_dartdevc.status:24: generic_local_functions_test:
CompileTimeError
On 2017/08/17 06:22:45, Jennifer Messerly wrote:
> some of these might duplicates with Analyzer issues, but I'm curious why these
> don't compile?

When I run analyzer on that test, I get:

"Analysis of generic function typed parameters is not yet supported"

And then some cascading failures based on that.

https://codereview.chromium.org/3001803002/diff/1/tests/language_2/language_2...
tests/language_2/language_2_dartdevc.status:25: generic_method_types_test/01:
RuntimeError
On 2017/08/17 06:22:45, Jennifer Messerly wrote:
> these should be in the $runtime != none section

Done.

https://codereview.chromium.org/3001803002/diff/1/tests/language_2/language_2...
tests/language_2/language_2_dartdevc.status:65: generic_instanceof_test:
RuntimeError # Issue 29920
On 2017/08/17 06:22:45, Jennifer Messerly wrote:
> is this a DDC or test issue? often these are strong mode runtime failures

That's for noticing this. The test was testing the old 1.0 subtyping where
"<int>[] is List<dynamic>" is true. Fixed the test and it's passing on dartdevc
and failing on the other platforms now.

> 
> FYI:
> 
> $ pkg/dev_compiler/tool/ddc <entry_point>
> 
> is a quick way to run stuff on node

Oh, neat! I didn't know about that. Alas, it doesn't give me any kind of useful
stack trace.

> $ pkg/dev_compiler/tool/ddw <entry_point>
> 
> is a quick way to debug stuff using devtool

Even better!

https://codereview.chromium.org/3001803002/diff/1/tests/language_2/language_2...
File tests/language_2/language_2_kernel.status (right):

https://codereview.chromium.org/3001803002/diff/1/tests/language_2/language_2...
tests/language_2/language_2_kernel.status:20: generic_methods_bounds_test/none:
Pass
On 2017/08/22 08:09:29, bkonyi wrote:
> On 2017/08/17 06:22:45, Jennifer Messerly wrote:
> > do the "Pass" lines need to be included?
> 
> My guess is that these tests are expected to fail elsewhere, and passing is
the
> exception? Generally there's not 'Pass' entries unless they're needed for some
> special case.

Yeah, I just did a bad job of merging in the status file updates here. Fixed.

[Jennifer Messerly, 2017-08-24 02:08:38]

lgtm

[Bob Nystrom, 2017-08-24 17:52:35]

Description was changed from

==========
Migrate block 114 (and some of 113).

generic_instanceof ... getter_closure_execution_order_test.

The main interesting one is generic_methods_type_expression_test. It
was testing old Dart 1.0-specific behavior and needed a lot of changes.
==========

to

==========
Migrate block 114 (and some of 113).

generic_instanceof ... getter_closure_execution_order_test.

The main interesting one is generic_methods_type_expression_test. It
was testing old Dart 1.0-specific behavior and needed a lot of changes.

R=jmesserly@google.com

Committed:
https://github.com/dart-lang/sdk/commit/615be6451e6e84820e52126e9167f0b21b23c493
==========

[Bob Nystrom, 2017-08-24 17:52:37]

Committed patchset #3 (id:40001) manually as
615be6451e6e84820e52126e9167f0b21b23c493.