Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3001793002: Migrated test block 171 to Dart 2.0. (Closed)

Created:
3 years, 4 months ago by bkonyi
Modified:
3 years, 3 months ago
Reviewers:
Bob Nystrom, jcollins
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrated test block 171 to Dart 2.0. R=rnystrom@google.com Moved schedule_microtask[2,3,5]_test off of package:test to package:async_helper and package:expect. Committed: https://github.com/dart-lang/sdk/commit/d08e59e09c195c9d85bf41dd043900cbc17130ce

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed Bob's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -1712 lines) Patch
D tests/lib/async/run_zoned1_test.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/lib/async/run_zoned4_test.dart View 1 chunk +0 lines, -16 lines 0 comments Download
D tests/lib/async/run_zoned5_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/lib/async/run_zoned6_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D tests/lib/async/run_zoned7_test.dart View 1 chunk +0 lines, -41 lines 0 comments Download
D tests/lib/async/run_zoned8_test.dart View 1 chunk +0 lines, -42 lines 0 comments Download
D tests/lib/async/run_zoned9_test.dart View 1 chunk +0 lines, -36 lines 0 comments Download
D tests/lib/async/schedule_microtask2_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/lib/async/schedule_microtask3_test.dart View 1 chunk +0 lines, -41 lines 0 comments Download
D tests/lib/async/schedule_microtask5_test.dart View 1 chunk +0 lines, -45 lines 0 comments Download
D tests/lib/async/schedule_microtask_test.dart View 1 chunk +0 lines, -94 lines 0 comments Download
D tests/lib/async/slow_consumer2_test.dart View 1 chunk +0 lines, -121 lines 0 comments Download
D tests/lib/async/slow_consumer3_test.dart View 1 chunk +0 lines, -92 lines 0 comments Download
D tests/lib/async/slow_consumer_test.dart View 1 chunk +0 lines, -123 lines 0 comments Download
D tests/lib/async/stack_trace01_test.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D tests/lib/async/stack_trace02_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D tests/lib/async/stack_trace03_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D tests/lib/async/stack_trace04_test.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D tests/lib/async/stack_trace05_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
M tests/lib/lib.status View 1 9 chunks +9 lines, -15 lines 0 comments Download
A + tests/lib_2/async/run_zoned1_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/run_zoned4_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/run_zoned5_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/run_zoned6_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/run_zoned7_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/run_zoned8_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/run_zoned9_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/schedule_microtask2_test.dart View 1 chunk +12 lines, -11 lines 0 comments Download
A tests/lib_2/async/schedule_microtask3_test.dart View 1 chunk +41 lines, -0 lines 0 comments Download
A tests/lib_2/async/schedule_microtask5_test.dart View 1 chunk +45 lines, -0 lines 0 comments Download
A + tests/lib_2/async/schedule_microtask_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/slow_consumer2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/slow_consumer3_test.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + tests/lib_2/async/slow_consumer_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/stack_trace01_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/stack_trace02_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/stack_trace03_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/stack_trace04_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/stack_trace05_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/lib_2/lib_2.status View 1 1 chunk +6 lines, -0 lines 0 comments Download
M tests/lib_2/lib_2_dart2js.status View 1 1 chunk +7 lines, -0 lines 0 comments Download
M tests/lib_2/lib_2_dartdevc.status View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/lib_2/lib_2_flutter.status View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tests/lib_2/lib_2_kernel.status View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/lib_2/lib_2_vm.status View 1 1 chunk +3 lines, -0 lines 0 comments Download
D tests/lib_strong/async/run_zoned1_test.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/lib_strong/async/run_zoned4_test.dart View 1 chunk +0 lines, -16 lines 0 comments Download
D tests/lib_strong/async/run_zoned5_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/lib_strong/async/run_zoned6_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D tests/lib_strong/async/run_zoned7_test.dart View 1 chunk +0 lines, -41 lines 0 comments Download
D tests/lib_strong/async/run_zoned8_test.dart View 1 chunk +0 lines, -42 lines 0 comments Download
D tests/lib_strong/async/run_zoned9_test.dart View 1 chunk +0 lines, -36 lines 0 comments Download
D tests/lib_strong/async/schedule_microtask2_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/lib_strong/async/schedule_microtask3_test.dart View 1 chunk +0 lines, -41 lines 0 comments Download
D tests/lib_strong/async/schedule_microtask5_test.dart View 1 chunk +0 lines, -45 lines 0 comments Download
D tests/lib_strong/async/schedule_microtask_test.dart View 1 chunk +0 lines, -94 lines 0 comments Download
D tests/lib_strong/async/slow_consumer2_test.dart View 1 chunk +0 lines, -121 lines 0 comments Download
D tests/lib_strong/async/slow_consumer3_test.dart View 1 chunk +0 lines, -92 lines 0 comments Download
D tests/lib_strong/async/slow_consumer_test.dart View 1 chunk +0 lines, -123 lines 0 comments Download
D tests/lib_strong/async/stack_trace01_test.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D tests/lib_strong/async/stack_trace02_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D tests/lib_strong/async/stack_trace03_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D tests/lib_strong/async/stack_trace04_test.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D tests/lib_strong/async/stack_trace05_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
M tests/lib_strong/lib_strong.status View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
bkonyi
3 years, 4 months ago (2017-08-16 18:03:57 UTC) #2
Bob Nystrom
lgtm https://codereview.chromium.org/3001793002/diff/1/tests/lib_2/async/slow_consumer3_test.dart File tests/lib_2/async/slow_consumer3_test.dart (right): https://codereview.chromium.org/3001793002/diff/1/tests/lib_2/async/slow_consumer3_test.dart#newcode17 tests/lib_2/async/slow_consumer3_test.dart:17: class SlowConsumer extends StreamConsumer<List> { Use List<int> here ...
3 years, 4 months ago (2017-08-23 21:49:32 UTC) #3
bkonyi
3 years, 3 months ago (2017-08-30 13:46:43 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
d08e59e09c195c9d85bf41dd043900cbc17130ce.

Powered by Google App Engine
This is Rietveld 408576698