Correctly handle adding imports when pasting into part files

Correctly handle adding imports when pasting into part files

R=devoncarew@google.com

Committed: https://github.com/dart-lang/sdk/commit/35f6d5da1bebfce3b25b328a37084b09b85c97fb

[Brian Wilkerson, 2017-08-15 17:12:31]

brianwilkerson@google.com changed reviewers:
+ devoncarew@google.com

[devoncarew, 2017-08-15 21:59:30]

lgtm

https://codereview.chromium.org/3001733002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/edit/edit_domain.dart (right):

https://codereview.chromium.org/3001733002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/edit/edit_domain.dart:403: // The file in the
request is a part of a library. We need to pass the
Just so I understand, if you pass a part into `edit.importElements`, you'll get
an error. It's the responsibility of the client to know to go from the part to
the defining library? (and, to gracefully handle errors)

[Brian Wilkerson, 2017-08-15 23:32:33]

https://codereview.chromium.org/3001733002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/edit/edit_domain.dart (right):

https://codereview.chromium.org/3001733002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/edit/edit_domain.dart:403: // The file in the
request is a part of a library. We need to pass the
> Just so I understand, if you pass a part into `edit.importElements`, you'll
get
> an error. It's the responsibility of the client to know to go from the part to
> the defining library? (and, to gracefully handle errors)

No. If the client passes a part into `edit.importElements`, it's the
responsibility of this method to find the defining compilation unit for the
library so that the library unit can be passed in to the
`ImportElementsComputer`. Clients are not expected to have enough Dart-specific
knowledge to find libraries associated with parts.

The client will only get an error if the file passed in to `edit.importElements`
isn't being analyzed or if the file is a part and we can't find the library that
the part belongs to. But, yes, the client needs to gracefully handle errors.

[devoncarew, 2017-08-15 23:37:15]

On 2017/08/15 23:32:33, Brian Wilkerson wrote:
>
https://codereview.chromium.org/3001733002/diff/1/pkg/analysis_server/lib/src...
> File pkg/analysis_server/lib/src/edit/edit_domain.dart (right):
> 
>
https://codereview.chromium.org/3001733002/diff/1/pkg/analysis_server/lib/src...
> pkg/analysis_server/lib/src/edit/edit_domain.dart:403: // The file in the
> request is a part of a library. We need to pass the
> > Just so I understand, if you pass a part into `edit.importElements`, you'll
> get
> > an error. It's the responsibility of the client to know to go from the part
to
> > the defining library? (and, to gracefully handle errors)
> 
> No. If the client passes a part into `edit.importElements`, it's the
> responsibility of this method to find the defining compilation unit for the
> library so that the library unit can be passed in to the
> `ImportElementsComputer`. Clients are not expected to have enough
Dart-specific
> knowledge to find libraries associated with parts.
> 
> The client will only get an error if the file passed in to
`edit.importElements`
> isn't being analyzed or if the file is a part and we can't find the library
that
> the part belongs to. But, yes, the client needs to gracefully handle errors.

Gotcha, thanks.

[Brian Wilkerson, 2017-08-16 14:43:34]

Description was changed from

==========
Correctly handle adding imports when pasting into part files
==========

to

==========
Correctly handle adding imports when pasting into part files

R=devoncarew@google.com

Committed:
https://github.com/dart-lang/sdk/commit/35f6d5da1bebfce3b25b328a37084b09b85c97fb
==========

[Brian Wilkerson, 2017-08-16 14:43:35]

Committed patchset #1 (id:1) manually as
35f6d5da1bebfce3b25b328a37084b09b85c97fb (presubmit successful).