Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 3001723002: Update edit.importElements response data to support part files (Closed)

Created:
3 years, 4 months ago by Brian Wilkerson
Modified:
3 years, 4 months ago
Reviewers:
devoncarew
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update edit.importElements response data to support part files R=devoncarew@google.com Committed: https://github.com/dart-lang/sdk/commit/44b5341de896d13a8a158597e2695afb893412d3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -40 lines) Patch
M pkg/analysis_server/lib/protocol/protocol_constants.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/protocol/protocol_generated.dart View 5 chunks +26 lines, -24 lines 0 comments Download
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/edit/import_elements_test.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/support/integration_test_methods.dart View 1 chunk +6 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/integration/support/protocol_matchers.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
This just updates the spec, generated files, and three places that needed to be updated ...
3 years, 4 months ago (2017-08-15 15:09:38 UTC) #2
devoncarew
lgtm
3 years, 4 months ago (2017-08-15 15:37:58 UTC) #3
Brian Wilkerson
3 years, 4 months ago (2017-08-15 15:51:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
44b5341de896d13a8a158597e2695afb893412d3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698