Update window region after widget resizes not changing HWND size

Update window region after widget resizes not changing HWND size

When width or height of a widget is changed to a value less than 64
pixels, it is rounded up to 64 pixels (see crbug.com/286609). This might
cause the actual HWND size remain the same while changing size of the
widget. In this case, we need to force message handler to update window
region since we are not receiving resize messages form the OS.

BUG=376329
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273081

[mohsen, 2014-05-26 19:00:35]

jbauman@: Can you take a look please...

[jbauman, 2014-05-27 16:44:14]

lgtm

[mohsen, 2014-05-27 17:07:17]

sky@: can you please take a look...

[sky, 2014-05-27 17:33:05]

https://codereview.chromium.org/300163002/diff/1/ui/views/widget/desktop_aura...
File ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc (right):

https://codereview.chromium.org/300163002/diff/1/ui/views/widget/desktop_aura...
ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc:489:
message_handler_->SetBounds(new_expanded);
You want the logic to be that even if SetBounds() doesn't cause a size change,
pretend it does. I think this would be better expressed by making SetBounds take
a boolean indicating this. Is that possible?

[mohsen, 2014-05-27 18:24:29]

https://codereview.chromium.org/300163002/diff/1/ui/views/widget/desktop_aura...
File ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc (right):

https://codereview.chromium.org/300163002/diff/1/ui/views/widget/desktop_aura...
ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc:489:
message_handler_->SetBounds(new_expanded);
On 2014/05/27 17:33:06, sky wrote:
> You want the logic to be that even if SetBounds() doesn't cause a size change,
> pretend it does. I think this would be better expressed by making SetBounds
take
> a boolean indicating this. Is that possible?

Yep. Done.

[sky, 2014-05-27 19:27:38]

LGTM

https://codereview.chromium.org/300163002/diff/20001/ui/views/win/hwnd_messag...
File ui/views/win/hwnd_message_handler.h (right):

https://codereview.chromium.org/300163002/diff/20001/ui/views/win/hwnd_messag...
ui/views/win/hwnd_message_handler.h:133: void SetBounds(const gfx::Rect&
bounds_in_pixels, bool widget_size_changed);
Document what widget_size_changed means. Also, how about naming it
force_size_changed.

[mohsen, 2014-05-27 20:16:17]

https://codereview.chromium.org/300163002/diff/20001/ui/views/win/hwnd_messag...
File ui/views/win/hwnd_message_handler.h (right):

https://codereview.chromium.org/300163002/diff/20001/ui/views/win/hwnd_messag...
ui/views/win/hwnd_message_handler.h:133: void SetBounds(const gfx::Rect&
bounds_in_pixels, bool widget_size_changed);
On 2014/05/27 19:27:39, sky wrote:
> Document what widget_size_changed means. Also, how about naming it
> force_size_changed.

Done.

[mohsen, 2014-05-27 22:50:59]

The CQ bit was checked by mohsen@chromium.org

[commit-bot: I haz the power, 2014-05-27 22:51:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mohsen@chromium.org/300163002/60001

[commit-bot: I haz the power, 2014-05-28 00:04:26]

Change committed as 273081