Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issue 3001513002: Add a prefix convention for tests in [dart|debugger]_api_impl_tests.cc. (Closed)

Created:
3 years, 4 months ago by sivachandra
Modified:
3 years, 4 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a prefix convention for tests in [dart|debugger]_api_impl_tests.cc. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/abf9eae3f7962692307573d7f262df33b4b7f99f

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -264 lines) Patch
M runtime/tests/vm/vm.status View 1 4 chunks +48 lines, -49 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 178 chunks +187 lines, -187 lines 0 comments Download
M runtime/vm/debugger_api_impl_test.cc View 26 chunks +28 lines, -28 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sivachandra
NFC. I want this so that it is easy for me to track what the ...
3 years, 4 months ago (2017-08-10 13:14:16 UTC) #2
siva
lgtm
3 years, 4 months ago (2017-08-10 15:06:12 UTC) #3
sivachandra
3 years, 4 months ago (2017-08-11 08:38:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
abf9eae3f7962692307573d7f262df33b4b7f99f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698