Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 3001473002: [vm] Fix flaky crash in StackTraceMallocHookLengthTest. (Closed)

Created:
3 years, 4 months ago by rmacnak
Modified:
3 years, 4 months ago
Reviewers:
bkonyi, zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org, zra
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[vm] Fix flaky crash in StackTraceMallocHookLengthTest. Remove double initialization of the allocation sample buffer, the second of which triggers the malloc hook. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/1398ee11af47200c88e3ffb91e1ccc43df0b5976

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M runtime/vm/malloc_hooks_test.cc View 2 chunks +1 line, -1 line 0 comments Download
M runtime/vm/profiler.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
rmacnak
3 years, 4 months ago (2017-08-09 23:00:04 UTC) #2
zra
lgtm
3 years, 4 months ago (2017-08-10 14:52:38 UTC) #4
rmacnak
3 years, 4 months ago (2017-08-10 16:52:32 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1398ee11af47200c88e3ffb91e1ccc43df0b5976 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698