Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Side by Side Diff: runtime/vm/object_service.cc

Issue 3001463002: [gardening] Revert "Eliminate dependencies on assemblers and code stubs in precompiled runtime." (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/redundancy_elimination.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/debugger.h" 5 #include "vm/debugger.h"
6 #include "vm/disassembler.h" 6 #include "vm/disassembler.h"
7 #include "vm/object.h" 7 #include "vm/object.h"
8 #include "vm/object_store.h" 8 #include "vm/object_store.h"
9 #include "vm/stub_code.h" 9 #include "vm/stub_code.h"
10 #include "vm/symbols.h" 10 #include "vm/symbols.h"
(...skipping 820 matching lines...) Expand 10 before | Expand all | Expand 10 after
831 func.AddProperty("name", vm_name); 831 func.AddProperty("name", vm_name);
832 AddNameProperties(&func, vm_name, vm_name); 832 AddNameProperties(&func, vm_name, vm_name);
833 } 833 }
834 jsobj.AddPropertyF("_startAddress", "%" Px "", PayloadStart()); 834 jsobj.AddPropertyF("_startAddress", "%" Px "", PayloadStart());
835 jsobj.AddPropertyF("_endAddress", "%" Px "", PayloadStart() + Size()); 835 jsobj.AddPropertyF("_endAddress", "%" Px "", PayloadStart() + Size());
836 jsobj.AddProperty("_alive", is_alive()); 836 jsobj.AddProperty("_alive", is_alive());
837 const ObjectPool& object_pool = ObjectPool::Handle(GetObjectPool()); 837 const ObjectPool& object_pool = ObjectPool::Handle(GetObjectPool());
838 jsobj.AddProperty("_objectPool", object_pool); 838 jsobj.AddProperty("_objectPool", object_pool);
839 { 839 {
840 JSONArray jsarr(&jsobj, "_disassembly"); 840 JSONArray jsarr(&jsobj, "_disassembly");
841 #if !defined(DART_PRECOMPILED_RUNTIME)
842 if (is_alive()) { 841 if (is_alive()) {
843 // Only disassemble alive code objects. 842 // Only disassemble alive code objects.
844 DisassembleToJSONStream formatter(jsarr); 843 DisassembleToJSONStream formatter(jsarr);
845 Disassemble(&formatter); 844 Disassemble(&formatter);
846 } 845 }
847 #endif // !defined(DART_PRECOMPILED_RUNTIME)
848 } 846 }
849 const PcDescriptors& descriptors = PcDescriptors::Handle(pc_descriptors()); 847 const PcDescriptors& descriptors = PcDescriptors::Handle(pc_descriptors());
850 if (!descriptors.IsNull()) { 848 if (!descriptors.IsNull()) {
851 JSONObject desc(&jsobj, "_descriptors"); 849 JSONObject desc(&jsobj, "_descriptors");
852 descriptors.PrintToJSONObject(&desc, false); 850 descriptors.PrintToJSONObject(&desc, false);
853 } 851 }
854 852
855 PrintJSONInlineIntervals(&jsobj); 853 PrintJSONInlineIntervals(&jsobj);
856 } 854 }
857 855
(...skipping 655 matching lines...) Expand 10 before | Expand all | Expand 10 after
1513 jsobj.AddProperty("mirrorReferent", referent_handle); 1511 jsobj.AddProperty("mirrorReferent", referent_handle);
1514 } 1512 }
1515 1513
1516 void UserTag::PrintJSONImpl(JSONStream* stream, bool ref) const { 1514 void UserTag::PrintJSONImpl(JSONStream* stream, bool ref) const {
1517 Instance::PrintJSONImpl(stream, ref); 1515 Instance::PrintJSONImpl(stream, ref);
1518 } 1516 }
1519 1517
1520 #endif 1518 #endif
1521 1519
1522 } // namespace dart 1520 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/redundancy_elimination.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698