Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Unified Diff: runtime/vm/intermediate_language_x64.cc

Issue 300143007: Generate better ARM64 code for indexed loads and stores. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_x64.cc
===================================================================
--- runtime/vm/intermediate_language_x64.cc (revision 36699)
+++ runtime/vm/intermediate_language_x64.cc (working copy)
@@ -1031,11 +1031,11 @@
void LoadIndexedInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
- Register array = locs()->in(0).reg();
- Location index = locs()->in(1);
+ // The array register points to the backing store for external arrays.
+ const Register array = locs()->in(0).reg();
+ const Location index = locs()->in(1);
- Address element_address(kNoRegister, 0);
- element_address = index.IsRegister()
+ Address element_address = index.IsRegister()
? ElementAddressForRegIndex(IsExternal(), class_id(), index_scale(),
array, index.reg())
: ElementAddressForIntIndex(IsExternal(), class_id(), index_scale(),
@@ -1202,11 +1202,11 @@
void StoreIndexedInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
- Register array = locs()->in(0).reg();
- Location index = locs()->in(1);
+ // The array register points to the backing store for external arrays.
+ const Register array = locs()->in(0).reg();
+ const Location index = locs()->in(1);
- Address element_address(kNoRegister, 0);
- element_address = index.IsRegister()
+ Address element_address = index.IsRegister()
? ElementAddressForRegIndex(IsExternal(), class_id(), index_scale(),
array, index.reg())
: ElementAddressForIntIndex(IsExternal(), class_id(), index_scale(),
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698