Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 3001383002: Add Mac support for isolates (Closed)

Created:
3 years, 4 months ago by Alexander Thomas
Modified:
3 years, 4 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add Mac support for isolates Remove commands to allow recipies to specify them Reduce duplication with includes Rename to more generic names (dart2js*.isolate wasn't just used for dartj2s) BUG= R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/bace5b330dc59e36ca97dc4f439cac113b409437

Patch Set 1 #

Patch Set 2 : Add missing comma to 'includes' entry. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -49 lines) Patch
D tools/bots/dart2js_tests.isolate View 1 chunk +0 lines, -22 lines 0 comments Download
D tools/bots/dart2js_tests_no_command.isolate View 1 chunk +0 lines, -21 lines 0 comments Download
M tools/bots/dart_tests.isolate View 2 chunks +4 lines, -6 lines 0 comments Download
A tools/bots/dart_tests_extended.isolate View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Alexander Thomas
3 years, 4 months ago (2017-08-22 14:19:19 UTC) #3
Bill Hesse
lgtm
3 years, 4 months ago (2017-08-22 14:49:55 UTC) #4
Alexander Thomas
3 years, 4 months ago (2017-08-22 15:15:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:10005) manually as
bace5b330dc59e36ca97dc4f439cac113b409437 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698